Prevent out-of-memory crashes using line length limits #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einfachIrgendwer0815
force-pushed
the
feature/line_length_limit
branch
from
e11770d
to
2f0faa2
Compare
einfachIrgendwer0815
force-pushed
the
feature/line_length_limit
branch
from
2f0faa2
to
55bebbb
Compare
Discards long lines to prevent out-of-memory events.
einfachIrgendwer0815
force-pushed
the
feature/line_length_limit
branch
from
55bebbb
to
d0bb0ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #636 with the solution proposed in this comment.
The limit at which reading continues but content gets discarded is now called "soft limit". Respectively, the limit at which bat will abort is now called "hard limit".
The default values for the soft and hard limits can be overwritten using the
--soft-line-limitand--hard-line-limitcli options.--disable-line-limitswill disable both limits.