Upgrade dependencies to fix rust nightly regression #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Component: Build
stevenengler
changed the title
github-actions
bot
added
the
Component: Testing
Previously shadow wouldn't compile on nightly due to a rust type inference change that breaks existing rust code, and they intend to stabilize this change. For us that breakage occurs in the time crate, so this PR upgrades all dependencies (including the time library) to fix the build errors. rust-lang/rust#99969 (comment) rust-lang/rust#125319
stevenengler
force-pushed
the
fix-broken-nightly
branch
from
527767e
to
5e2eb8a
Compare
github-actions
bot
removed
the
Component: Testing
robgjansen
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously shadow wouldn't compile on nightly due to a rust compiler type inference change that breaks existing rust code, and they intend to stabilize this change in a couple of months. For us that breakage occurs in the time crate, so this PR upgrades all dependencies (including the time library) to fix the build error.
rust-lang/rust#99969 (comment)
rust-lang/rust#125319
The upgraded schemars version did change the cli output, specifically the displayed default values ofOptionarguments. I don't think there's much we can do about this, and it's not a big deal. I updated the test for the new cli output.Edit: The schemars issue has now been fixed, so I upgraded the dependencies again. There is now no change to the cli output.