feat(slider): add vertical slider support and update docs #2586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds vertical slider support for the
<Slider>
component. It closes #2186Intuition
radix/primitive
slider comes with both "horizontal" and "vertical" support, it injects the orientation prop asdata-orientation
attribute to the primitive components. Hence, I think it is straight-forward and simpler for us to just tap on thedata-orientation
attribute to change our component classes accordingly using Tailwind's built-indata-*
modifier (see: https://tailwindcss.com/docs/hover-focus-and-other-states#attribute-selectors )Changes
slider-horizontal-demo
and I created aslider-vertical-demo
default
andnew-york
to support vertical orientationw-full
, or a vertical slider hash-full
) So it is parent's container's responsibility to determine the width of the horizontal slider, or the height of the vertical slider.docs/component/slider.mdx
to showcase both horizontal and vertical slider sample codes, as well as explaining the usage of setting optionalorientation="vertical"
to create a vertical slider. Also added examples to our sinkDemo
video demo link:
https://github.com/shadcn-ui/ui/assets/44829092/dd3f5e3f-b37a-4ac1-8b4a-6bf213c69a51