This repository has been archived by the owner on May 13, 2024. It is now read-only.
Fix #115: Custom validation closure does not exist and is bypassed #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the instance property responsible for collection of custom closures in the
Validation
class is not properly initialized.The
customClosures
property defaults to an empty object{}
that is never populated in the constructor.On the other hand, an erroneous
validationClosures
property is initialized, but is never read from.The fix is to initialize
customClosures
object properly, and custom validators will suddenly start working: