This repository has been archived by the owner on May 13, 2024. It is now read-only.

Fix #113: Impossible to turn off validation error alert #114

Open

dvuckovic wants to merge 2 commits into sethsandaru:master from wolfnetics:issue/113-validation-error-alert

dvuckovic commented Dec 31, 2021

Issue #113 stems from a faulty assignment in the plugin installer:

    // show alert or not?
    formDI.validationErrorShowAlert = properties.validationErrorShowAlert || true

This will always default to true value in case properties.validationErrorShowAlert is "falsy".

We can fix this by checking if the option was defined first, and assign the default only if it wasn't.

     // show alert or not?
-    formDI.validationErrorShowAlert = properties.validationErrorShowAlert || true
+    formDI.validationErrorShowAlert = typeof properties.validationErrorShowAlert !== 'undefined'
+        ? Boolean(properties.validationErrorShowAlert)
+        : true

dvuckovic added 2 commits

December 31, 2021 10:35


Fixed sethsandaru#113: Impossible to turn off validation error alert.

cb8979d


Tidied.

2a56bb7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.