servoshell: Support Cursor::None and all winit keys #32228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atouchet
reviewed
May 5, 2024
Nopey
changed the title
atouchet
reviewed
May 6, 2024
atbrakhi
reviewed
May 6, 2024
Nopey
force-pushed
the
more-input
branch
3 times, most recently
from
6e3a9ed
to
3d0f866
Compare
mrobinson
approved these changes
May 13, 2024
keyboard-types has been bumped to 0.7, and stylo bumped to latest main (as of 2024-05-05) for their bump to kbd-types 0.7.
mrobinson
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cursor::None now hides the cursor, and more keys from winit are supported.
Exhaustive matching is used where possible, keys that are intentionally mapped to Unidentified are now explicitly matched as such (where previously this was documented in a comment).
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors