Update to Rust 1.78 #32217

sagudev · 2024-05-02T12:30:45Z

Somebody asked for it.

Everybody will need to rerun mach bootstrap to rebuild crown (can we do this automatically?).

Requires new version of ipc-channel.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes (compiler and crown tests)

support/crown/src/unrooted_must_root.rs

support/crown/src/common.rs

support/crown/Cargo.toml

sagudev · 2024-05-03T07:07:25Z

@mrobinson land it, if it is OK.

support/crown/Cargo.toml

support/crown/src/common.rs

sagudev · 2024-05-04T05:57:29Z

CRASH [expected OK] /_webgl/conformance/more/functions/texImage2DBadArgs.html
CRASH [expected OK] /_webgl/conformance/textures/misc/gl-teximage.html

This could be due to LLVM bump in rust.

jschwe · 2024-05-04T06:13:20Z

   │ unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (thread Script(1,1), at library/core/src/panicking.rs:156)

I believe its the debug assertions being enabled in the standard library now in Rust 1.78.

sagudev · 2024-05-04T06:13:20Z

_webgl/conformance/more/functions/texImage2DBadArgs.html:

unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (thread Script(1,1), at library/core/src/panicking.rs:156)
 0:02.48 pid:62526    0: servoshell::backtrace::print
 0:02.48 pid:62526    1: servoshell::main::{{closure}}
 0:02.48 pid:62526    2: std::panicking::rust_panic_with_hook
 0:02.48 pid:62526    3: std::panicking::begin_panic_handler::{{closure}}
 0:02.48 pid:62526    4: std::sys_common::backtrace::__rust_end_short_backtrace
 0:02.48 pid:62526    5: rust_begin_unwind
 0:02.48 pid:62526    6: core::panicking::panic_nounwind_fmt
 0:02.48 pid:62526    7: core::panicking::panic_nounwind
 0:02.48 pid:62526    8: ipc_channel::platform::unix::OsIpcSharedMemory::from_bytes
 0:02.48 pid:62526    9: ipc_channel::ipc::IpcSharedMemory::from_bytes
 0:02.48 pid:62526   10: <script::dom::webglrenderingcontext::WebGLRenderingContext as script::dom::bindings::codegen::Bindings::WebGLRenderingContextBinding::WebGLRenderingContext_Binding::WebGLRenderingContextMethods>::TexImage2D
 0:02.48 pid:62526   11: script::dom::bindings::codegen::Bindings::WebGLRenderingContextBinding::WebGLRenderingContext_Binding::texImage2D::{{closure}}
 0:02.48 pid:62526   12: mozjs::panic::wrap_panic
 0:02.48 pid:62526   13: script::dom::bindings::codegen::Bindings::WebGLRenderingContextBinding::WebGLRenderingContext_Binding::texImage2D
 0:02.48 pid:62526   14: CallJitMethodOp
 0:02.48 pid:62526   15: script::dom::bindings::utils::generic_call
 0:02.48 pid:62526   16: _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructENS_10CallReasonE
 0:02.48 pid:62526   17: _ZN2js4CallEP9JSContextN2JS6HandleINS2_5ValueEEES5_RKNS_13AnyInvokeArgsENS2_13MutableHandleIS4_EENS_10CallReasonE
 0:02.48 pid:62526   18: _ZN2js9fun_applyEP9JSContextjPN2JS5ValueE
 0:02.48 pid:62526   19: _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructENS_10CallReasonE
 0:02.48 pid:62526   20: _ZN2js9InterpretEP9JSContextRNS_8RunStateE
 0:02.48 pid:62526   21: _ZN2js9RunScriptEP9JSContextRNS_8RunStateE
 0:02.48 pid:62526   22: _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructENS_10CallReasonE
 0:02.48 pid:62526   23: _ZN2js4CallEP9JSContextN2JS6HandleINS2_5ValueEEES5_RKNS_13AnyInvokeArgsENS2_13MutableHandleIS4_EENS_10CallReasonE
 0:02.48 pid:62526   24: _ZN2js9fun_applyEP9JSContextjPN2JS5ValueE
 0:02.48 pid:62526   25: _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructENS_10CallReasonE
 0:02.48 pid:62526   26: _ZN2js3jit14DoCallFallbackEP9JSContextPNS0_13BaselineFrameEPNS0_14ICFallbackStubEjPN2JS5ValueENS7_13MutableHandleIS8_EE
 0:02.48 pid:62526   27: <unknown>
 0:02.48 pid:62526   28: <unknown>
 0:02.48 pid:62526   29: <unknown>
 0:02.48 pid:62526   30: <unknown>
 0:02.48 pid:62526   31: _ZN2js3jit32EnterBaselineInterpreterAtBranchEP9JSContextPNS_16InterpreterFrameEPh
 0:02.48 pid:62526   32: <unknown>
 0:02.48 pid:62526 mozilla::detail::MutexImpl::~MutexImpl: pthread_mutex_destroy failed: Device or resource busy
 0:02.48 pid:62526 Caught signal 11thread panicked while processing panic. aborting.
 0:02.49 pid:62526 Redirecting call to abort() to mozalloc_abort
 0:02.49 pid:62526 
 0:02.61 TEST_END: CRASH, expected OK

_webgl/conformance/textures/misc/gl-teximage.html

pid:60975 unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (thread Script(1,1), at library/core/src/panicking.rs:156)
 0:03.09 pid:60975    0: servoshell::backtrace::print
 0:03.09 pid:60975    1: servoshell::main::{{closure}}
 0:03.09 pid:60975    2: std::panicking::rust_panic_with_hook
 0:03.09 pid:60975    3: std::panicking::begin_panic_handler::{{closure}}
 0:03.09 pid:60975    4: std::sys_common::backtrace::__rust_end_short_backtrace
 0:03.09 pid:60975    5: rust_begin_unwind
 0:03.09 pid:60975    6: core::panicking::panic_nounwind_fmt
 0:03.09 pid:60975    7: core::panicking::panic_nounwind
 0:03.09 pid:60975    8: ipc_channel::platform::unix::OsIpcSharedMemory::from_bytes
 0:03.10 pid:60975    9: ipc_channel::ipc::IpcSharedMemory::from_bytes
 0:03.10 pid:60975   10: <script::dom::webglrenderingcontext::WebGLRenderingContext as script::dom::bindings::codegen::Bindings::WebGLRenderingContextBinding::WebGLRenderingContext_Binding::WebGLRenderingContextMethods>::TexImage2D
 0:03.10 pid:60975   11: script::dom::bindings::codegen::Bindings::WebGLRenderingContextBinding::WebGLRenderingContext_Binding::texImage2D::{{closure}}
 0:03.10 pid:60975   12: mozjs::panic::wrap_panic
 0:03.10 pid:60975   13: script::dom::bindings::codegen::Bindings::WebGLRenderingContextBinding::WebGLRenderingContext_Binding::texImage2D
 0:03.10 pid:60975   14: CallJitMethodOp
 0:03.10 pid:60975   15: script::dom::bindings::utils::generic_call
 0:03.10 pid:60975   16: _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructENS_10CallReasonE
 0:03.10 pid:60975   17: _ZN2js3jit14DoCallFallbackEP9JSContextPNS0_13BaselineFrameEPNS0_14ICFallbackStubEjPN2JS5ValueENS7_13MutableHandleIS8_EE
 0:03.10 pid:60975   18: <unknown>
 0:03.10 pid:60975   19: <unknown>
 0:03.10 pid:60975   20: <unknown>
 0:03.10 pid:60975   21: <unknown>
 0:03.10 pid:60975   22: _ZN2js3jit32EnterBaselineInterpreterAtBranchEP9JSContextPNS_16InterpreterFrameEPh
 0:03.10 pid:60975 mozilla::detail::MutexImpl::~MutexImpl: pthread_mutex_destroy failed: Device or resource busy
 0:03.10 pid:60975 Caught signal 11thread panicked while processing panic. aborting.
 0:03.10 pid:60975 Redirecting call to abort() to mozalloc_abort
 0:03.10 pid:60975 
 0:03.24 TEST_END: CRASH, expected OK

sagudev · 2024-05-04T06:14:54Z

   │ unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (thread Script(1,1), at library/core/src/panicking.rs:156)

I believe its the debug assertions being enabled in the standard library now in Rust 1.78.

Right, that makes much more sense.

sagudev · 2024-05-04T06:58:03Z

Apparently destination pointer is null although it shouldn't be as this was checked upon it's creation: https://github.com/sagudev/ipc-channel/blob/4c01b78a108d761ac67407da1359b8293c7c93ef/src/platform/unix/mod.rs#L803

sagudev · 2024-05-04T07:04:45Z

Note that even if the effectively copied size (count * size_of::()) is 0, the pointers must be non-null and properly aligned.

sagudev · 2024-05-04T07:26:24Z

Related: servo/ipc-channel#268

github-actions · 2024-05-04T15:58:37Z

🔨 Triggering try run (#8951653290) for Linux WPT, MacOS, Windows, Android

sagudev · 2024-05-04T15:58:41Z

Testing servo/ipc-channel#335

github-actions · 2024-05-04T16:13:11Z

🔨 Triggering try run (#8951738888) for Linux WPT, MacOS, Windows, Android

github-actions · 2024-05-04T17:05:44Z

Test results for linux-wpt-layout-2013 from try job (#8951738888):

Flaky unexpected result (15)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works.
```
Test timed out
```

OK /_mozilla/css/offset_properties_inline.html

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

FAIL [expected PASS] subtest: offsetWidth

assert_equals: offsetWidth of #inline-1 should be 30. expected 30 but got 22

FAIL [expected PASS] subtest: offsetHeight

assert_equals: offsetHeight of #inline-1 should be 10. expected 10 but got 12

OK /cors/preflight-failure.htm (#22339)
- FAIL [expected PASS] subtest: Should succeed if preflight has status 299
```
assert_false: expected false got true
```

OK /css/css-fonts/variations/font-weight-matching.html (#20686)

PASS [expected FAIL] subtest: Test @font-face matching for weight 249

FAIL [expected PASS] subtest: Test @font-face matching for weight 250

assert_approx_equals: @font-face should be mapped to CSSTest Weights 800. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 400

assert_approx_equals: @font-face should be mapped to CSSTest Weights 700. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 500

assert_approx_equals: @font-face should be mapped to CSSTest Weights 300. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 750

assert_approx_equals: @font-face should be mapped to CSSTest Weights 200. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 900

assert_approx_equals: @font-face should be mapped to CSSTest Weights 100. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 1000

assert_approx_equals: @font-face should be mapped to CSSTest Weights 100. expected 90 +/- 2 but got 180

TIMEOUT [expected OK] /custom-elements/reactions/customized-builtins/HTMLMediaElement.html (#31014)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- PASS [expected FAIL] subtest: first argument: absolute url
CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.attributes.parse.minus.html
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: \r\n in name (normal form)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in filename (formdata event)
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- TIMEOUT [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
```
Test timed out
```
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```

Stable unexpected results that are known to be intermittent (8)

FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
CRASH [expected PASS] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 5813504 but got 5814016
```

Stable unexpected results (25)

CRASH [expected FAIL] /html/canvas/element/2d.text-outside-of-the-flat-tree.html
CRASH [expected PASS] /html/canvas/element/reset/2d.reset.render.text.html
CRASH [expected OK] /html/canvas/element/text/2d.text.draw.fill.maxWidth.small.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps1.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps3.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps4.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps5.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps6.html
CRASH [expected FAIL] /html/canvas/element/text/direction-inherit-rtl.html
CRASH [expected PASS] /html/canvas/element/text/direction-ltr.html
CRASH [expected FAIL] /html/canvas/element/text/direction-rtl.html
CRASH [expected PASS] /html/canvas/offscreen/reset/2d.reset.render.text.html
CRASH [expected TIMEOUT] /html/canvas/offscreen/reset/2d.reset.render.text.w.html
CRASH [expected OK] /html/canvas/offscreen/text/2d.text.draw.fill.maxWidth.small.html
CRASH [expected OK] /html/canvas/offscreen/text/2d.text.draw.fill.maxWidth.small.worker.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps1.html
CRASH [expected TIMEOUT] /html/canvas/offscreen/text/2d.text.fontVariantCaps1.w.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps3.html
CRASH [expected TIMEOUT] /html/canvas/offscreen/text/2d.text.fontVariantCaps3.w.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps4.html
CRASH [expected TIMEOUT] /html/canvas/offscreen/text/2d.text.fontVariantCaps4.w.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps5.html
CRASH [expected TIMEOUT] /html/canvas/offscreen/text/2d.text.fontVariantCaps5.w.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps6.html
CRASH [expected TIMEOUT] /html/canvas/offscreen/text/2d.text.fontVariantCaps6.w.html

github-actions · 2024-05-04T17:13:09Z

Test results for linux-wpt-layout-2020 from try job (#8951738888):

Flaky unexpected result (15)

OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg 10deg' over 'oblique 5deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 10deg' over 'italic'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -10deg' should prefer 'oblique 0deg 10deg' over 'oblique 40deg 50deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique -10deg' over 'italic'

OK /css/css-values/cap-invalidation.html

FAIL [expected PASS] subtest: CSS Values and Units Test: cap invalidation

uncaught exception: Error: assert_not_equals: expect the capital height of Ahem and sans-serif to be different got disallowed value 371.3333333333333

OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- FAIL [expected PASS] subtest: looks up handleEvent method on every event dispatch
```
assert_equals: expected 1 but got 0
```
OK /css/cssom-view/MediaQueryListEvent.html (#25275)
- FAIL [expected PASS] subtest: argument of addListener
```
assert_true: expected true got false
```
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Newline normalization - \n in value (urlencoded)
CRASH [expected PASS] /encoding/streams/stringification-crash.html
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
TIMEOUT [expected OK] /html/browsers/history/the-location-interface/assign-with-nested-iframe.html
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-user-activation-sticky.tentative.sub.window.html (#32154)
- TIMEOUT [expected FAIL] subtest: Allow top with user activation + user activation
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: backslash in value (normal form)
ERROR [expected OK] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document

Stable unexpected results that are known to be intermittent (12)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
OK /css/cssom-view/MediaQueryList-extends-EventTarget-interop.html (#25285)
- PASS [expected FAIL] subtest: listener added with addListener and addEventListener is called once
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
CRASH [expected PASS] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- TIMEOUT [expected PASS] subtest: Verifies that location navigations take precedence when following form submissions.
```
Test timed out
```

Stable unexpected results (17)

CRASH [expected FAIL] /html/canvas/element/2d.text-outside-of-the-flat-tree.html
CRASH [expected PASS] /html/canvas/element/reset/2d.reset.render.text.html
CRASH [expected OK] /html/canvas/element/text/2d.text.draw.fill.maxWidth.small.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps1.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps3.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps4.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps5.html
CRASH [expected PASS] /html/canvas/element/text/2d.text.fontVariantCaps6.html
CRASH [expected FAIL] /html/canvas/element/text/direction-inherit-rtl.html
CRASH [expected PASS] /html/canvas/element/text/direction-ltr.html
CRASH [expected FAIL] /html/canvas/element/text/direction-rtl.html
CRASH [expected FAIL] /html/canvas/offscreen/reset/2d.reset.render.text.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps1.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps3.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps4.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps5.html
CRASH [expected PASS] /html/canvas/offscreen/text/2d.text.fontVariantCaps6.html

github-actions · 2024-05-04T17:13:21Z

⚠️ Try run (#8951738888) failed.

sagudev · 2024-05-04T17:18:58Z

I guess there are even more debug assert failures, this time unrelated to ipc-channel. (I somehow knew, that it was to good to be true for whole repo to be good; although why they were not triggered before? rebase?).

EDIT: I think rebase helps as I cannot reproduce it on my machine.

github-actions · 2024-05-04T17:25:37Z

🔨 Triggering try run (#8952142892) for Linux WPT

github-actions · 2024-05-04T18:08:04Z

Test results for linux-wpt-layout-2013 from try job (#8952142892):

Flaky unexpected result (17)

OK /_mozilla/css/stylesheet_media_queries.html (#17159)
- FAIL [expected PASS] subtest: Media queries within stylesheets
```
assert_equals: expected "rgb(0, 255, 0)" but got "rgb(255, 0, 0)"
```
TIMEOUT [expected PASS] /css/css-color/animation/opacity-animation-ending-correctly-002.html (#29216)
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- FAIL [expected PASS] subtest: listeners are called correct number of times
```
assert_equals: expected 1 but got 0
```
TIMEOUT [expected OK] /custom-elements/reactions/customized-builtins/HTMLMediaElement.html (#31014)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
TIMEOUT /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
- TIMEOUT [expected FAIL] subtest: origin referrer policy used to create the starting page
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: no-referrer referrer policy used to create the starting page
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.html
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Area element should support autofocus
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: single quote in name (formdata event)
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- TIMEOUT [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
```
Test timed out
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```

Stable unexpected results that are known to be intermittent (9)

FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored
```
assert_equals: expected "?pass" but got "?fail"
```
CRASH [expected TIMEOUT] /html/dom/documents/dom-tree-accessors/Document.currentScript.html (#22423)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
OK /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
TIMEOUT [expected OK] /performance-timeline/not-restored-reasons/performance-navigation-timing-iframes-without-attributes.tentative.window.html (#32213)
- TIMEOUT [expected FAIL] subtest: RemoteContextHelper navigation using BFCache
```
Test timed out
```
TIMEOUT [expected OK] /performance-timeline/not-restored-reasons/performance-navigation-timing-navigation-failure.tentative.window.html (#32226)
- TIMEOUT [expected FAIL] subtest: Ensure that navigation failure blocks bfcache and gets recorded.
```
Test timed out
```

github-actions · 2024-05-04T18:09:19Z

Test results for linux-wpt-layout-2020 from try job (#8952142892):

Flaky unexpected result (16)

TIMEOUT [expected OK] /FileAPI/url/url-charset.window.html (#26997)
- TIMEOUT [expected PASS] subtest: Blob charset should override any auto-detected charset.
```
Test timed out
```

OK /_mozilla/css/offset_properties_inline.html

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

FAIL [expected PASS] /_mozilla/mozilla/iframe/resize_after_load.html (#13573)
CRASH [expected PASS] /_webgl/conformance/glsl/bugs/sketchfab-lighting-shader-crash.html
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-stretch: '110%' should prefer '105%' over '100%'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 10deg' should prefer 'oblique 0deg' over 'oblique -50deg -20deg'
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored
```
assert_equals: expected "?pass" but got "?fail"
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/read-media/pageload-image-in-popup.html (#23849)
- NOTRUN [expected FAIL] subtest: The document for a standalone media file should have one child in the body.
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-cross-site.tentative.sub.window.html (#31754)
- TIMEOUT [expected FAIL] subtest: A cross-site unsandboxed iframe navigation consumes user activation and disallows top-level navigation.
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic File test (formdata event)
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise
```
Test timed out
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank

Stable unexpected results that are known to be intermittent (14)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
OK /css/cssom-view/MediaQueryList-extends-EventTarget-interop.html (#25285)
- PASS [expected FAIL] subtest: listener added with addListener and addEventListener is called once
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
```
assert_unreached: load should not be fired Reached unreachable code
```
CRASH [expected TIMEOUT] /html/dom/documents/dom-tree-accessors/Document.currentScript.html (#22423)
TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
Test timed out
```
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
ERROR [expected OK] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html (#29137)
- FAIL [expected PASS] subtest: document.write in an imported module
```
assert_true: onload must be called expected true got false
```
TIMEOUT [expected OK] /performance-timeline/not-restored-reasons/performance-navigation-timing-iframes-without-attributes.tentative.window.html (#32213)
- TIMEOUT [expected FAIL] subtest: RemoteContextHelper navigation using BFCache
```
Test timed out
```
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

github-actions · 2024-05-04T18:09:30Z

✨ Try run (#8952142892) succeeded.

sagudev · 2024-05-09T08:03:58Z

TODO: Do fixme from #32262.

jschwe · 2024-05-15T18:57:20Z

@sagudev Is servo/ipc-channel#335 the last thing that is blocking the Rust 1.78 upgrade, or are there any other failures?

sagudev · 2024-05-15T19:30:35Z

@sagudev Is servo/ipc-channel#335 the last thing that is blocking the Rust 1.78 upgrade, or are there any other failures?

servo/ipc-channel#335 is the only blocker (we also need to release new version after landing).

Co-authored-by: Martin Robinson <[email protected]>

sagudev · 2024-05-16T06:52:04Z

Rebased.

github-actions · 2024-05-16T06:52:35Z

🔨 Triggering try run (#9107815799) for Windows

github-actions · 2024-05-16T07:00:46Z

⚠️ Try run (#9107815799) failed.

This comment was marked as resolved.

Sign in to view

sagudev marked this pull request as ready for review May 3, 2024 05:11

sagudev requested a review from mrobinson May 3, 2024 05:14

mrobinson approved these changes May 3, 2024

View reviewed changes

support/crown/src/unrooted_must_root.rs Show resolved Hide resolved

support/crown/src/common.rs Outdated Show resolved Hide resolved

support/crown/Cargo.toml Outdated Show resolved Hide resolved

mrobinson approved these changes May 4, 2024

View reviewed changes

support/crown/Cargo.toml Outdated Show resolved Hide resolved

support/crown/src/common.rs Outdated Show resolved Hide resolved

support/crown/src/common.rs Outdated Show resolved Hide resolved

mrobinson enabled auto-merge May 4, 2024 04:23

mrobinson added this pull request to the merge queue May 4, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 4, 2024

sagudev added the T-full Do a full try run label May 4, 2024

github-actions bot removed the T-full Do a full try run label May 4, 2024

sagudev force-pushed the rust178 branch from 8bd680a to 628e3ef Compare May 4, 2024 16:02

sagudev added the T-full Do a full try run label May 4, 2024

github-actions bot removed the T-full Do a full try run label May 4, 2024

sagudev force-pushed the rust178 branch from 628e3ef to dd43325 Compare May 4, 2024 17:12

sagudev added the T-linux-wpt-2013 Do a try run of the WPT (legacy layout) label May 4, 2024

sagudev added the T-linux-wpt-2020 Do a try run of the WPT label May 4, 2024

github-actions bot removed T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels May 4, 2024

sagudev and others added 9 commits May 16, 2024 08:51

Update to rust 1.78

58b002d

Update crown for rust 1.78

c781400

rust 1.78 is now stable

cb60c38

Update for nix

928b9cf

Update comment

dc2cf3f

Co-authored-by: Martin Robinson <[email protected]>

Update support/crown/src/common.rs

bf078ed

Update support/crown/Cargo.toml

2b6797e

Update support/crown/src/common.rs

ad02723

Fix ipc problem

ceb0562

sagudev force-pushed the rust178 branch from 637729b to ceb0562 Compare May 16, 2024 06:51

sagudev added the T-windows Do a try run on Windows label May 16, 2024

github-actions bot removed the T-windows Do a try run on Windows label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Rust 1.78 #32217

Update to Rust 1.78 #32217

sagudev commented May 2, 2024 •

edited

This comment was marked as resolved.

sagudev commented May 3, 2024

sagudev commented May 4, 2024

jschwe commented May 4, 2024

sagudev commented May 4, 2024

sagudev commented May 4, 2024

sagudev commented May 4, 2024

sagudev commented May 4, 2024

sagudev commented May 4, 2024

github-actions bot commented May 4, 2024

sagudev commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

sagudev commented May 4, 2024 •

edited

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

sagudev commented May 9, 2024

jschwe commented May 15, 2024

sagudev commented May 15, 2024 •

edited

sagudev commented May 16, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

Update to Rust 1.78 #32217

Are you sure you want to change the base?

Update to Rust 1.78 #32217

Conversation

sagudev commented May 2, 2024 • edited

This comment was marked as resolved.

sagudev commented May 3, 2024

sagudev commented May 4, 2024

jschwe commented May 4, 2024

sagudev commented May 4, 2024

sagudev commented May 4, 2024

sagudev commented May 4, 2024

sagudev commented May 4, 2024

sagudev commented May 4, 2024

github-actions bot commented May 4, 2024

sagudev commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

sagudev commented May 4, 2024 • edited

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

github-actions bot commented May 4, 2024

sagudev commented May 9, 2024

jschwe commented May 15, 2024

sagudev commented May 15, 2024 • edited

sagudev commented May 16, 2024

github-actions bot commented May 16, 2024

github-actions bot commented May 16, 2024

sagudev commented May 2, 2024 •

edited

sagudev commented May 4, 2024 •

edited

sagudev commented May 15, 2024 •

edited