layout: Have `TextRun::glyph_run_is_preserved_newline` take into account `TextRunSegment` offset #32119

mrobinson · 2024-04-20T13:35:11Z

A TextRun is composed of TextRunSegments that are composed of GlyphRuns.
TextRun::glyph_run_is_preserved_newline is indexing into the TextRun
text, but the GlyphRun indexes that it uses are relative to the TextRunSegment
offset. Before the code was using the offset without incorporating the
TextRunSegment offset. This led to miscalculation of preserved newline
location while processing text content.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

github-actions · 2024-04-20T13:36:36Z

🔨 Triggering try run (#8765452871) for Linux WPT

github-actions · 2024-04-20T14:17:16Z

Test results for linux-wpt-layout-2020 from try job (#8765452871):

Flaky unexpected result (21)

FAIL [expected PASS] /_mozilla/mozilla/iframe/resize_after_load.html (#13573)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
OK /css/css-fonts/variations/font-weight-matching.html (#20686)
- PASS [expected FAIL] subtest: Test @font-face matching for weight 400
- PASS [expected FAIL] subtest: Test @font-face matching for weight 420
OK /css/cssom-view/matchMedia.html (#31428)
- PASS [expected FAIL] subtest: iframe.matchMedia("(width: 200px)") matches
TIMEOUT [expected OK] /custom-elements/reactions/customized-builtins/HTMLMediaElement.html (#31014)
TIMEOUT [expected OK] /encoding/legacy-mb-korean/euc-kr/euckr-encode-form-iso-ir-149.html?2001-3000
- NOTRUN [expected PASS] subtest: U+6AA3 檣 %ED%EA
- NOTRUN [expected PASS] subtest: U+6AB3 檳 %DE%B1
- NOTRUN [expected PASS] subtest: U+6ABB 檻 %F9%E3
- NOTRUN [expected PASS] subtest: U+6AC2 櫂 %D4%A2
- NOTRUN [expected PASS] subtest: U+6AC3 櫃 %CF%F6
- NOTRUN [expected PASS] subtest: U+6AD3 櫓 %D6%D0
- NOTRUN [expected PASS] subtest: U+6ADA 櫚 %D5%EA
- NOTRUN [expected PASS] subtest: U+6ADB 櫛 %F1%EE
- NOTRUN [expected PASS] subtest: U+6AF6 櫶 %FA%CB
- NOTRUN [expected PASS] subtest: U+6AFB 櫻 %E5%A1
- And 190 more unexpected results...
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout
```
assert_equals: Expected nested setTimeout to run second expected true but got false
```
- FAIL [expected PASS] subtest: Check execution order on load handler
```
assert_equals: Expected onload to run first expected false but got true
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Non-HTMLElement should not support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-cross-site.tentative.sub.window.html (#31754)
- TIMEOUT [expected FAIL] subtest: A cross-site unsandboxed iframe navigation consumes user activation and disallows top-level navigation.
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-same-site.tentative.sub.window.html (#32117)
- TIMEOUT [expected FAIL] subtest: A same-site unsandboxed iframe navigation does not consume user activation and allows top-level navigation.
```
Test timed out
```
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
ERROR [expected OK] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
CRASH [expected OK] /referrer-policy/gen/iframe.http-rp/origin/iframe-tag.http.html
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

Stable unexpected results that are known to be intermittent (8)

TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- FAIL [expected TIMEOUT] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected NOTRUN] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected NOTRUN] subtest: sec-fetch-mode - Not sent to non-trustworthy same-site destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected NOTRUN] subtest: sec-fetch-mode - Not sent to non-trustworthy cross-site destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- TIMEOUT [expected NOTRUN] subtest: sec-fetch-dest - Not sent to non-trustworthy same-origin destination, no attributes
```
Test timed out
```

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

TIMEOUT [expected OK] /html/browsers/history/the-location-interface/assign-replace-from-iframe.html (#31638)
- TIMEOUT [expected PASS] subtest: Browser sends Referer header in iframe request when location.replace is called from an iframe
```
Test timed out
```
- TIMEOUT [expected PASS] subtest: Browser sends Referer header in iframe request when location.assign is called from an iframe
```
Test timed out
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
- PASS [expected FAIL] subtest: document.write in an imported module
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

Stable unexpected results (1)

PASS [expected FAIL] /css/css-text/bidi/bidi-lines-001.html

github-actions · 2024-04-20T14:17:29Z

⚠️ Try run (#8765452871) failed.

…unt `TextRunSegment` offset A `TextRun` is composed of `TextRunSegment`s that are composed of `GlyphRun`s. `TextRun::glyph_run_is_preserved_newline` is indexing into the `TextRun` text, but the `GlyphRun` indexes that it uses are relative to the `TextRunSegment` offset. Before the code was using the offset without incorporating the `TextRunSegment` offset. This led to miscalculation of preserved newline location while processing text content.

github-actions · 2024-04-21T14:57:55Z

🔨 Triggering try run (#8773526689) for Linux WPT

github-actions · 2024-04-21T15:42:23Z

Test results for linux-wpt-layout-2020 from try job (#8773526689):

Flaky unexpected result (20)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
OK /css/css-fonts/variations/font-weight-matching.html (#20686)
- PASS [expected FAIL] subtest: Test @font-face matching for weight 420
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
TIMEOUT /fetch/fetch-later/new-window.tentative.https.window.html (#32036)
- TIMEOUT [expected FAIL] subtest: A same-origin window[target=''][features='0'] can trigger fetchLater.
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: A same-origin window[target=''][features='1'] can trigger fetchLater.
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: A same-origin window[target=''][features='2'] can trigger fetchLater.
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: A same-origin window[target='_blank'][features='0'] can trigger fetchLater.
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: A same-origin window[target='_blank'][features='1'] can trigger fetchLater.
```
Test timed out
```
- TIMEOUT [expected FAIL] subtest: A same-origin window[target='_blank'][features='2'] can trigger fetchLater.
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/browsing-the-web/overlapping-navigations-and-traversals/cross-document-nav-cross-document-nav.html (#29181)
- PASS [expected FAIL] subtest: cross-document navigation then cross-document navigation
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK [expected CRASH] /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- FAIL [expected TIMEOUT] subtest: opener of discarded auxiliary browsing context
```
assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 8016896 but got 8016640
```
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank
```
Test timed out
```
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

Stable unexpected results that are known to be intermittent (14)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
TIMEOUT /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected TIMEOUT] subtest: sec-fetch-site - Cross-site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- TIMEOUT [expected NOTRUN] subtest: sec-fetch-site - Same site, no attributes
```
Test timed out
```
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
- TIMEOUT [expected PASS] subtest: no-referrer referrer policy used to create the starting page
```
Test timed out
```
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/track/track-element/no-cuechange-before-play.html (#31014)
- FAIL [expected TIMEOUT] subtest: Ensure that the 'cuechange' event is not fired before video playback has begun.
```
assert_true: Not expecting event, but got canplaythrough event expected true got false
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK /html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-width-1000px.html (#21666)
- FAIL [expected PASS] subtest: <img srcset="/images/green-1x1.png?e38 50w, /images/green-16x16.png?e38 51w" sizes="(min-width:calc(0)) 1px"> ref sizes="1px" (width:1000px)
```
assert_equals: expected "http://web-platform.test:8000/images/green-1x1.png" but got "http://web-platform.test:8000/images/green-16x16.png"
```
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: 0x00 in name (normal form)
```
assert_equals: expected "a%00b=c" but got ""
```
ERROR [expected OK] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank

github-actions · 2024-04-21T15:42:33Z

✨ Try run (#8773526689) succeeded.

mrobinson added the T-linux-wpt-2020 Do a try run of the WPT label Apr 20, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Apr 20, 2024

mrobinson force-pushed the fix-newline-detection branch from 7460bf1 to 3017003 Compare April 21, 2024 14:48

mrobinson marked this pull request as ready for review April 21, 2024 14:57

mrobinson added the T-linux-wpt-2020 Do a try run of the WPT label Apr 21, 2024

mrobinson requested a review from Loirooriol April 21, 2024 14:57

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Apr 21, 2024

Loirooriol approved these changes Apr 21, 2024

View reviewed changes

mrobinson added this pull request to the merge queue Apr 21, 2024

Merged via the queue into servo:main with commit a7838ae Apr 21, 2024
37 checks passed

mrobinson deleted the fix-newline-detection branch April 21, 2024 21:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

layout: Have `TextRun::glyph_run_is_preserved_newline` take into account `TextRunSegment` offset #32119

layout: Have `TextRun::glyph_run_is_preserved_newline` take into account `TextRunSegment` offset #32119

mrobinson commented Apr 20, 2024

github-actions bot commented Apr 20, 2024

github-actions bot commented Apr 20, 2024

github-actions bot commented Apr 20, 2024

github-actions bot commented Apr 21, 2024

github-actions bot commented Apr 21, 2024

github-actions bot commented Apr 21, 2024

layout: Have TextRun::glyph_run_is_preserved_newline take into account TextRunSegment offset #32119

layout: Have TextRun::glyph_run_is_preserved_newline take into account TextRunSegment offset #32119

Conversation

mrobinson commented Apr 20, 2024

github-actions bot commented Apr 20, 2024

github-actions bot commented Apr 20, 2024

github-actions bot commented Apr 20, 2024

github-actions bot commented Apr 21, 2024

github-actions bot commented Apr 21, 2024

github-actions bot commented Apr 21, 2024

layout: Have `TextRun::glyph_run_is_preserved_newline` take into account `TextRunSegment` offset #32119

layout: Have `TextRun::glyph_run_is_preserved_newline` take into account `TextRunSegment` offset #32119