Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add status tooltips #32011

Merged
merged 2 commits into from May 21, 2024
Merged

feat: add status tooltips #32011

merged 2 commits into from May 21, 2024
+39 −5

Conversation

iterminatorheart
Copy link
Contributor

  • There are tests for these changes OR
  • These changes do not require tests because ___

@iterminatorheart iterminatorheart mentioned this pull request Apr 7, 2024
Closed
@iterminatorheart iterminatorheart force-pushed the feat/status_tooltip branch 2 times, most recently from a807737 to f8ca586 Compare April 7, 2024 16:14
sagudev
sagudev reviewed Apr 7, 2024
View reviewed changes
ports/servoshell/webview.rs Outdated Show resolved Hide resolved
@sagudev sagudev requested a review from delan April 7, 2024 19:50
@iterminatorheart iterminatorheart force-pushed the feat/status_tooltip branch 5 times, most recently from 35ce190 to 3a49a89 Compare April 12, 2024 13:26
delan
delan requested changes May 1, 2024
View reviewed changes
Copy link
Sponsor Member

@delan delan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming along well! A few comments:

ports/servoshell/minibrowser.rs Outdated Show resolved Hide resolved
ports/servoshell/minibrowser.rs Outdated Show resolved Hide resolved
ports/servoshell/webview.rs Outdated Show resolved Hide resolved
ports/servoshell/webview.rs Outdated Show resolved Hide resolved
ports/servoshell/minibrowser.rs Outdated Show resolved Hide resolved
ports/servoshell/minibrowser.rs Outdated Show resolved Hide resolved
@delan delan mentioned this pull request May 1, 2024
Closed
4 tasks
atbrakhi
atbrakhi approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@atbrakhi atbrakhi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iterminatorheart your changes looks good. I have rebased the PR and addressed delan's comment. We should be able to land this.

@delan delan self-requested a review May 21, 2024 10:36
@delan delan enabled auto-merge May 21, 2024 10:36
@delan delan added this pull request to the merge queue May 21, 2024
Merged via the queue into servo:main with commit 9d57c0d May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagudev sagudev sagudev left review comments

@delan delan delan approved these changes

@atbrakhi atbrakhi atbrakhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

servoshell: show a status bar tooltip when hovering over links
4 participants
@iterminatorheart @delan @sagudev @atbrakhi