[WIP]: Improve how intrinsic sizes work for videos #31746
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
Co-authored-by: Josh Matthews <[email protected]>
eerii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements improved layout rules for video elements, including aspect ratios and removed poster/src elements. The base for this pr is the patch provided by @jdm in #31416 (comment).
The pr fixes the result of the wpt tests defined in intrinsic_sizes.htm. The relevant natural width/height specification is available at https://html.spec.whatwg.org/multipage/media.html#concept-video-intrinsic-width.
This change depends on #31706, since that fixes the
onloadedmetadataevent firing correctly. This was tested locally using that patch and all the tests pass. However, until that is merged, the 4th test will fail.Needs changes after video autoplay rework in servo/media.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors