GStreamer default media backend #30420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagudev
changed the title
mrobinson
requested changes
Sep 28, 2023
mrobinson
reviewed
Sep 28, 2023
Comment on lines
+915
to
+917
|
|
||
| if self.media_stack.is_dummy() and "--no-default-features" not in cargo_args: | ||
| args += ["--no-default-features"] |
There was a problem hiding this comment.
Hrm. There is an issue here and it's that using the dummy media stack disables the "max_log_level", "native-bluetooth", and "webdriver" features. Perhaps we should make these features non-configurable? I'm not sure what the right thing to do here is.
There was a problem hiding this comment.
Ah, that's why I wanted ports so I could detect which features to enable. Webdriver should probably be hidden behind pref.
We could also move gstreamer enabling into cargo per target, then mach would only need to handle cross and forced dummy cases.
inspiration: https://stackoverflow.com/questions/57972355/enable-a-cargo-feature-by-default-when-the-target-arch-is-wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try run: https://github.com/sagudev/servo/actions/runs/6289052004
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors