fix: custom resource runtime upgrade #12334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update custom resource runtime from 16 to 18
marslan02
approved these changes
Jan 30, 2024
|
Seems duplicate of #12311 |
|
That will not be enough ... the more correct implementation => #12146 |
|
Thanks for looking at this @marslan02 and @tonivdv. This is a duplicate of #12311 - so I will close it. #12146 is making the equivalent change in main. This PR , and #12311 are not targeting main. They are merging into the version 2 tag. So I don't think that everything in #12146 is needed for #12311 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS is deprecating the node js v16 lambda runtime. This PR upgrades to node 18.
Reading the contribution guide lines here: https://github.com/talis/serverless/blob/main/CONTRIBUTING.md#when-you-propose-a-new-feature-or-bug-fix
I'm classifying this as an "Obvious bug fix/Maintenance improvement" - so there is not an issue number linked to this PR.
This is very similar to #12055 which bumped the version from 12 to 16.