replaced jszip with adm-zip, removed serverless v2 support, migrated from tape to jest #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AndrewChubatiuk 👋 Thanks a lot for sharing the PR. Unfortunately, the scope of this is way too big to be considered for a detailed review. Could you please break it down into smaller chunks? Maybe we could start with switch to adm-zip? I'd love to see the perf improvements. Let me know what do you think 🙇 |
AndrewChubatiuk
force-pushed
the
replaced-jszip-with-adm-zip
branch
from
9ca49cd
to
7a3c613
Compare
…from tape to jest
AndrewChubatiuk
force-pushed
the
replaced-jszip-with-adm-zip
branch
from
7a3c613
to
978fe03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
Sorry for a big diff. I've started only with a migration from jszip to adm-zip due to a poor performance of jszip, but ended with: