Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug logs for command execution failure #713

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

estahn
Copy link

@estahn estahn commented Jul 28, 2022

If docker command execution fails due to a bad Dockerfile the error will always be docker not found. This will allow to output the actual exception instead.

If docker command execution fails due to a bad `Dockerfile` the error will always be `docker not found`. This will allow to output the actual exception instead.
@pgrzesik
Copy link
Collaborator

pgrzesik commented Oct 1, 2022

Hey @estahn - thanks for the proposal. Could you provide a reproduction case for the situation you've mentioned? I see that the error will be docker not found only in the situations where the command not found will be found in output. Otherwise, the original error is thrown. Are you observing different behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants