Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding support for failure policy #132

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Adding support for failure policy #132

wants to merge 4 commits into from

Conversation

patrickhousley
Copy link

This PR adds support for setting eventTrigger failurePolicy on individual functions.

@zdraganov
Copy link

Related to #131

@zdraganov
Copy link

zdraganov commented Jan 4, 2019 •
edited

@patrickhousley it's good to add something into the README when you are extending current code

@patrickbrandt
Copy link

@patrickhousley ^

@patrickhousley
Copy link
Author

Sorry fellows, been on vacation. So I would normally agree if the README was actually used for documentation. However, it is not in this repo. I will leave it to the repo maintainers to decide how best to document this change.

@patrickhousley
Copy link
Author

Is this going to be merged? If not, please close it and explain why.

@teddy-codes
Copy link

LGTM?

@hjaurum
Copy link

hjaurum commented Nov 4, 2019

can merge this PR? really need it ~

@buffolander
Copy link

buffolander commented Dec 8, 2019 •
edited


is anyone gonna merge this PR? @pmuens

@gretro
Copy link

gretro commented Jan 7, 2020

Is there a plan to merge this PR? It would be helpful.

@paulohpigatto
Copy link

Is this PR still active? The changes would be extremely useful

@frandiox
Copy link

frandiox commented Jun 5, 2020

@patrickhousley Thanks for the PR! Just pinging in case you didn't notice the tests failed. It seems easy to fix and perhaps we can ping the other collaborators after tests pass to get this merged.

EthanChouTW added a commit to AlleyPin/serverless-google-cloudfunctions that referenced this pull request Jul 22, 2020
@EthanChouTW
feat: adding support for failure policy
6404a47 
following serverless#132
@EthanChouTW EthanChouTW mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickdekkers mickdekkers mickdekkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@patrickhousley @zdraganov @patrickbrandt @teddy-codes @hjaurum @buffolander @gretro @paulohpigatto @frandiox @mickdekkers