Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support wrapping ESM-based functions #692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pgrzesik
Copy link
Contributor

No description provided.

@pgrzesik pgrzesik self-assigned this Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #692 (575457a) into main (225b570) will increase coverage by 0.30%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
+ Coverage   50.31%   50.61%   +0.30%     
==========================================
  Files          92       92              
  Lines        2572     2590      +18     
==========================================
+ Hits         1294     1311      +17     
- Misses       1278     1279       +1     
Impacted Files Coverage Δ
lib/wrap.js 96.96% <95.65%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225b570...575457a. Read the comment docs.

@codingnuclei
Copy link

Hi,

First off thanks for all the great work.
Really like the idea of supporting files in the esm format.

Was just thinking - any chance we could make the wrapper function extension agnostic? It would be nice for it to support the .mjs extension.

@jsmithdev jsmithdev mentioned this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants