Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Update ruby version used in CI to 3.3 #296

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

rvem
Copy link
Member

@rvem rvem commented Jan 31, 2024

Description

Explicitly pin ruby and danger versions in CI to avoid the situation when the latest danger version (which is used by the action by default) becomes incompatible with the used ruby version (due to version requirements for some transitive danger dependencies).
An example of such incompatibility: https://github.com/serokell/xrefcheck/pull/294/checks#step:4:15

Related issue(s)

Fixes #

✅ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • Any modifications of public contracts comply with the Evolution
      of Public Contracts
      policy.
    • I added an entry to the changelog if my changes are visible to the users
      and
    • provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

✓ Release Checklist

  • I updated the version number in package.yaml.
  • I updated the changelog and moved everything
    under the "Unreleased" section to a new section for this release version.
  • (After merging) I edited the auto-release.
    • Change the tag and title using the format vX.Y.Z.
    • Write a summary of all user-facing changes.
    • Deselect the "This is a pre-release" checkbox at the bottom.
  • (After merging) I updated xrefcheck-action.
  • (After merging) I uploaded the package to hackage.

@rvem rvem force-pushed the rvem/chore-update-ruby-version-in-ci branch from 89c670b to 9aa91d1 Compare January 31, 2024 13:37
@rvem rvem force-pushed the rvem/chore-update-ruby-version-in-ci branch from 9aa91d1 to cc40a23 Compare January 31, 2024 13:40
@rvem rvem requested a review from Martoon-00 January 31, 2024 13:45
@rvem rvem marked this pull request as ready for review January 31, 2024 13:45
@rvem rvem enabled auto-merge January 31, 2024 13:45
@rvem rvem self-assigned this Jan 31, 2024
@rvem rvem merged commit b370667 into master Jan 31, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the rvem/chore-update-ruby-version-in-ci branch January 31, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants