Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add serilogtracing link #137

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

liammclennan
Copy link

No description provided.

@nblumhardt
Copy link
Member

Typo in there, mentions Seq while this repo is OTLP.

I think this could be confusing right now, because Serilog.Sinks.OpenTelemetry doesn't support SerilogTracing.

I'd like to open a discussion around whether that might change, since the SerilogTracing.Sinks.OpenTelemetry fork is otherwise pretty much identical to the original code here, and a lot of people working with OTLP will inevitably want to capture some trace data. It'll need a new ticket, though :-)

@liammclennan
Copy link
Author

image

@nblumhardt
Copy link
Member

I still think this would be way more compelling (and a bit less confusing) if the message was consider using SerilogTracing with this sink. I'll scope out and raise that ticket, and then loop back here :)

@nblumhardt nblumhardt marked this pull request as draft June 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants