Add support for multiple delimiters in PacketLengthParser, as well as delimiters of sizes > 1 byte #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So there's at least one other person who wants this. |
|
Is there any chance this will get merged? |
I wish I'm not sure who to @ to move this along I ended up building my branch into the projects I'm using this for feel free to do the same, kind of annoying bc it doesn't publish anywhere but not the end of the world |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used this for a situation where the delimiter can be many different things each specific delimiter denotes a type of packet, and because there are so many it has to be multiple bytes. This doesn't break any existing functionality and consumers do not need to use this if they stick with the defaults.
I've updated the documentation for this here
serialport/website#125