Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages to allow building with OpenSSL 1.1.1 #426

Closed

Conversation

ColonelThirtyTwo
Copy link

native-tls v0.1.5 does not detect OpenSSL 1.1.1 when building, causing
compile errors on systems that have it installed (such as Arch).

This patch swaps out the outdated evzht9h3nznqzwl crate with its upstream
websocket crate.

Fixes #394

cargo test passes, and my light testing of my bot confirms that both chat and voice work.

native-tls v0.1.5 does not detect OpenSSL 1.1.1 when building, causing
compile errors on systems that have it installed (such as Arch).

This patch swaps out the outdated evzht9h3nznqzwl crate with its upstream
websocket crate.

Fixes serenity-rs#394
@Lakelezz Lakelezz added the fix A solution to an existing bug. label Nov 6, 2018
@Lakelezz
Copy link
Contributor

Lakelezz commented Nov 8, 2018

Thanks for your pull request.

Nonetheless, as pointed out in #394, the issue websockets-rs/rust-websocket#137 in websocket-rs is critical.

Therefore an update of the respective dependency would require our related fix to be integrated into websocket-rs. Although an alternative would be updating evzht9h3nznqzwl itself.

@Lakelezz Lakelezz closed this Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A solution to an existing bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants