fix: overhaul test suite of attribute(s)ToSQL
#17121
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Attempt 2 on overhauling the test suite for
attributesToSQL
andattributeToSQL
. I also did some minor improvements to the functions.Closes #15533
TODOs
attributeToSQL
attributesToSQL
Future PRs
attributesToSql
andattributeToSql
respectivelyattributesToSQL
to queryGenerator so both can become internal functionscomment
for sqlite)attribute(s)ToSQL
(breaking change)List of Breaking Changes