en.chat4o.com #92
en.chat4o.com #92
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #92 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 1 1
Lines 239 239
Branches 63 63
=======================================
Hits 217 217
Misses 19 19
Partials 3 3Continue to review full report at Codecov.
|
|
UPDATE : Note : We will drop |
art/art_dic.py
Outdated
| "cigarette1": "()___)____________)", | ||
| "cigarette2": "(____((____________()~~~", | ||
| "cigarette3": "(̅_̅_̅_̅(̅_̅_̅_̅_̅_̅_̅_̅_̅̅_̅()ڪے", |
There was a problem hiding this comment.
could you please change cigarette1 and cigarette3?
cigarette3 seems to be a more realistic model for cigarette 🚬
There was a problem hiding this comment.
Good point!
Done 750a601
art/art_dic.py
Outdated
| @@ -468,5 +468,6 @@ | |||
| "surprised2": "(O_o)", | |||
| "boombox2": "♫♪ |̲̅̅●̲̅̅|̲̅̅=̲̅̅|̲̅̅●̲̅̅| ♫♪", | |||
| "equalizer": "▇ ▅ █ ▅ ▇ ▂ ▃ ▁ ▁ ▅ ▃ ▅ ▅ ▄ ▅ ▇", | |||
| "playing cards": "[♥]]] [♦]]] [♣]]] [♠]]]" | |||
There was a problem hiding this comment.
can we divide this art into 4 art?
like "playing cards hearts" : "[♥]]]" and ...
There was a problem hiding this comment.
I checked the link, i think these are interesting sets and worth adding, i didn't catch your point about smallness of these sets.
if it is OK for i can add this link to Font and Art suggestion
There was a problem hiding this comment.
I checked the link, i think these are interesting sets and worth adding, i didn't catch your point about smallness of these sets.
if it is OK for i can add this link to Font and Art suggestion
Okay, I entrust it to you ;-)
art/art_dic.py
Outdated
| "playing cards clubs": "[♣]]]", | ||
| "black spade": "♠", | ||
| "black heart": "♥", | ||
| "black diamond": "♦", | ||
| "black club": "♣", | ||
| "white spade": "♤", | ||
| "white heart": "♡", | ||
| "white diamond": "♢", | ||
| "white club": "♧" |
There was a problem hiding this comment.
Can we consider a better name for these sets?
black sets are colorful in some operating systems and i think bold heart and so on and regular hear and ... or any other suitable name.
Reference Issues/PRs
#91 #90
What does this implement/fix? Explain your changes.
1. mouse4
2. pistols3
3. rock on2
4. love in my eye2
5. love in my eye3
6. sad3
7. sad4
8. headphone2
9. cigarette3
10. spider3
11. barcode2
12. equalizer
13. boombox2
14. surprised2
15. playing cards
16. playing cards hearts
17. playing cards diamonds
18. playing cards spades
19. playing cards clubs
20. spade bold
21. heart bold
22. diamond bold
23. club bold
24. spade regular
25. heart regular
26. diamond regular
27. club regular
barcode1-line art renamed tobarcode1cigaret1-line art renamed tocigarette1cigarette1-line art renamed tocigarette2headphone1-line art renamed toheadphone1rock on1-line art renamed torock on1boom box1-line art renamed toboombox1love in my eye1-line art renamed tolove in my eye1Any other comments?
After this PR, we will be good to go for next release (
version 4.4)