Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collections should be defined at the project root and not relative to playbooks path #1660

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RusticPotatoes
Copy link

@RusticPotatoes RusticPotatoes commented Dec 2, 2023

collections was being referenced from the playbooks relative directory and should be from the projects root directory. updated roles for consistency on path joining. thanks @andreas-marschke for the original find, updating the current codebase as there has been so many changes.

if a playbook is in <proj_root>/sub_folder/playbook.yml the previous code expects collections to be in the sub_folder directory <proj_root>/sub_folder/collections/requirements.yml.

my proposed changes sets the collections directory to always be in the projects root folder as it does for roles directory currently.

Now it will look for collections in <proj_root>/collections/requirements.yml as expected.

this resolves issue #1144 for No collections requirements file found

@RusticPotatoes RusticPotatoes changed the title roles and collections should be defined at the root collections should be defined at the project root and not relative to playbooks path Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant