collections should be defined at the project root and not relative to playbooks path #1660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collections was being referenced from the playbooks relative directory and should be from the projects root directory. updated roles for consistency on path joining. thanks @andreas-marschke for the original find, updating the current codebase as there has been so many changes.
if a playbook is in <proj_root>/sub_folder/playbook.yml the previous code expects collections to be in the sub_folder directory <proj_root>/sub_folder/collections/requirements.yml.
my proposed changes sets the collections directory to always be in the projects root folder as it does for roles directory currently.
Now it will look for collections in <proj_root>/collections/requirements.yml as expected.
this resolves issue #1144 for No collections requirements file found