Add: Environment module support YAML format #319 #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for YAML in environment form, it's possible to choose YAML for extra vars and JSON for Environment or any combination you like. It's completely written in frontend. Whatever format you choose it will end up as json and sent to the database. It's not really best practice everywhere, I made decision to rather forgo that than to rip up the backend, database, etc. This is functionality that is really needed so I went with it. The ugliest part of the code which I am a bit torn about is the parseErrorString function. It will just string replace JSON to YAML when needed but it wouldn't completely wrong to let it say JSON since that is actually what the backend receives.
This solves: #319 and also #1141, it wasn't my intention to fix #1141 as well, there was just no way around it.
So if this pull request get's merged this pull request #1651 is obsolete.