Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mysql connect no keep alive #1259

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Fushengliangnian
Copy link

No operation for a long time. mysql is invalid connection

@fiftin
Copy link
Collaborator

fiftin commented Jul 3, 2023

Hi @Fushengliangnian

Thank you for you PR!

I think Close should stop pinging database.

I will review it soon.

@Fushengliangnian
Copy link
Author

Thank recover.

This question has been bothering me for a long time.

I hope you can let me know when the repair is finished.

My English is very poor, please forgive me if the expression is not accurate

Thanks a million!!!

@andreas-marschke
Copy link
Collaborator

@Fushengliangnian @fiftin I think this isn't the best solution to the problem.
A better one would be to review this: http://go-database-sql.org/connection-pool.html and see if we can allow for the MaxIdle connections to be configurable including timeout so that people can adjust this based on their MySQL server setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants