Improve virtual touch target positioning for narrow elements #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c677675 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
reviewed
May 16, 2024
packages/braid-design-system/src/lib/components/Accordion/AccordionItem.css.ts
Show resolved
Hide resolved
askoufis
reviewed
May 16, 2024
packages/braid-design-system/src/lib/components/private/touchable/virtualTouchableRules.ts
Show resolved
Hide resolved
michaeltaranto
commented
May 16, 2024
packages/braid-design-system/src/lib/components/private/touchable/debugTouchable.ts
Show resolved
Hide resolved
askoufis
approved these changes
May 19, 2024
Co-authored-by: Adam Skoufis <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve virtual touch target positioning for narrow elements
To maintain accessibility for smaller interactive elements, Braid uses a virtual touch target to maintain the minimum hit area This change ensures that the virtual element is always centered to the visual target, in particular when the width of the visual target is narrower than the minimum hit area.
Dev note
Moved style composition of virtual touch targets into Vanilla Extract style sheets as a minor optimisation.