Fix cmake gnu conventions #52
Conversation
SoapGentoo
force-pushed
the
fix-cmake-gnu-conventions
branch
from
8174196
to
7b0a312
Compare
CMakeLists.txt
Outdated
| set_target_properties(libtelnet | ||
| PROPERTIES | ||
| VERSION ${PROJECT_VERSION} | ||
| SOVERSION ${PROJECT_VERSION}) |
There was a problem hiding this comment.
NAK on this line: current master branch uses -version-info 2:0:0, so using PROJECT_VERSION would result in 0.30.0 which cannot be desired...
There was a problem hiding this comment.
We can change it to 2 if you prefer, it's just that the current situation is just as bad, namely that it adds no SOVERSION
There was a problem hiding this comment.
The proper way would be to check whether/how the ABI changed... I agree that the current situation is bad and I would call it a regression compared to the former autotools approach... but when adding SOVERSION now we should take the time required to make it a real solution...
There was a problem hiding this comment.
Repushed, now:
readelf -d temp/usr/local/lib64/liblibtelnet.so | grep SONAME
0x000000000000000e (SONAME) Library soname: [liblibtelnet.so.2]
Which mirrors the output of -version-info 2:0:0
There was a problem hiding this comment.
I could live with this, thanks 👍
SoapGentoo
force-pushed
the
fix-cmake-gnu-conventions
branch
from
7b0a312
to
b40b2ac
Compare
|
merged in fluffos@b70c7e8 |
SoapGentoo
force-pushed
the
fix-cmake-gnu-conventions
branch
from
b40b2ac
to
095054b
Compare
|
@Shea690901 any chance of getting this merged? |
Hi @seanmiddleditch
I'd like to merge some fixes that are important for packages, as they improve make handling libtelnet for us downstream much easier.