Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: makefile project engineering design and build design #2161

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

cubxxw
Copy link
Collaborator

@cubxxw cubxxw commented Apr 1, 2023

Signed-off-by: Xinwei Xiong(cubxxw) [email protected]

Describe what this PR does / why we need it

Does this pull request fix one issue?

Fixes #2148

Describe how you did it

Describe how to verify it

Special notes for reviews

@cubxxw cubxxw closed this Apr 1, 2023
@cubxxw cubxxw reopened this Apr 3, 2023
@github-actions github-actions bot added the ImageBuilding related to all staff with image building label Apr 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -11.17 ⚠️

Comparison is base (150c4cb) 19.93% compared to head (d093afc) 8.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2161       +/-   ##
==========================================
- Coverage   19.93%   8.77%   -11.17%     
==========================================
  Files          98     165       +67     
  Lines        9220   13805     +4585     
==========================================
- Hits         1838    1211      -627     
- Misses       7128   12438     +5310     
+ Partials      254     156       -98     
Flag Coverage Δ
e2e-tests 8.77% <ø> (?)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 263 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mouuii
Copy link

mouuii commented Apr 4, 2023

rebase to serval commits

@starnop
Copy link
Collaborator

starnop commented Apr 28, 2023

@cubxxw Cloud you please add more description for this PR?

cubxxw added 9 commits May 6, 2023 19:38
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
makefile:What is needed to preserve it

save makefile

add makefile go.build as dirty

Add the images and copyright portions of the makefile

Clear the output directory to tools.clean

add help info for samll makefile

Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>

The help information is built

End help, Color and case

Complete the makefile tools section

Finish implementing the code generator

Initialize Initialize the contributor file

Remove some irrelevant directories

Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>

fix: part about build issues

Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>

fix: part about build issues

Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
@cubxxw cubxxw changed the title 【draft】Design pre-version storage feat: makefile project engineering design and build design May 6, 2023
@cubxxw cubxxw marked this pull request as ready for review May 6, 2023 15:05
@cubxxw
Copy link
Collaborator Author

cubxxw commented May 6, 2023

After completing the basic tests, I will create a design document in the form of Google Docs and sync it to an issue.

cubxxw added 3 commits May 7, 2023 15:50
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong(cubxxw) <[email protected]>
@cubxxw
Copy link
Collaborator Author

cubxxw commented May 7, 2023

# sealer build use BUILD_TOOLS
BUILD_TOOLS ?= golangci-lint goimports addlicense deepcopy-gen conversion-gen ginkgo go-junit-report
# Code analysis tools
ANALYSIS_TOOLS = golangci-lint goimports golines go-callvis kube-score
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need all those tools ?

# docker registry: registry.example.com/namespace/image:tag as: registry.hub.docker.com/cubxxw/<image-name>:<tag>
#

DOCKER := docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this image.mk do? do we need it ?

}
//TODO!
// missinfo := []string{}
// if OutputInfo.KubernetesVersion == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version just show sealer git info. no need to include cluster info. or we can support it later by using another cmd.

return versionCmd
}

func PrintInfo() error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we split those code optimization from this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clusterfile ImageBuilding related to all staff with image building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Sealer Makefile optimization
5 participants