Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saving container image optional #1851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Nov 11, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Fixes #1849

Describe how you did it

Describe how to verify it

Special notes for reviews

@YTGhost YTGhost force-pushed the saving-container-image-optional branch from 23dcc5a to 8e41a35 Compare November 11, 2022 03:31
cmd/sealer/cmd/image/build.go Outdated Show resolved Hide resolved
cmd/sealer/cmd/image/build.go Outdated Show resolved Hide resolved
@YTGhost YTGhost force-pushed the saving-container-image-optional branch from 8e41a35 to 87643e8 Compare November 12, 2022 12:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Base: 21.65% // Head: 21.65% // No change to project coverage 👍

Coverage data is based on head (a834725) compared to base (f9cc112).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1851   +/-   ##
=======================================
  Coverage   21.65%   21.65%           
=======================================
  Files          72       72           
  Lines        6586     6586           
=======================================
  Hits         1426     1426           
  Misses       4974     4974           
  Partials      186      186           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YTGhost YTGhost force-pushed the saving-container-image-optional branch from 87643e8 to a834725 Compare November 12, 2022 12:36
@@ -92,6 +92,7 @@ func NewBuildCmd() *cobra.Command {
buildCmd.Flags().StringSliceVar(&buildFlags.Annotations, "annotation", []string{}, "add annotations for image. Format like --annotation key=[value]")
buildCmd.Flags().StringSliceVar(&buildFlags.Labels, "label", []string{getSealerLabel()}, "add labels for image. Format like --label key=[value]")
buildCmd.Flags().BoolVar(&buildFlags.NoCache, "no-cache", false, "do not use existing cached images for building. Build from the start with a new set of cached layers.")
buildCmd.Flags().BoolVarP(&buildFlags.DownloadContainerImage, "download-container-image", "d", true, "save the container image generated during the build process.")
Copy link
Collaborator

@starnop starnop Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about adding a new flag like buildMode?

And different build mode means different logic of execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sealer build make saving container image feature is optional
4 participants