Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bracket matching customization #320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove bracket matching customization #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 2 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ As of 1.0.0, there's a Light Owl Theme too! Color balanced from the Dark version
About this theme, and some of the considerations made while creating it (as well as _how_ to create it should you want to make your own): [https://css-tricks.com/creating-a-vs-code-theme/](https://css-tricks.com/creating-a-vs-code-theme/)

## Night Owl

![First Screen](first-screen.jpg)
![Night Owl Frameworks](three-dark.jpg)

## Light Owl

![First Screen Light](light-owl-full.jpg)
![Light Owl Frameworks](three-light.jpg)

Expand Down Expand Up @@ -65,15 +67,13 @@ The community is awesome and has ported this theme over to other environments.
- Windows Terminal [https://github.com/edurojasr/Windows_Terminal_Theme_Night_Owl](https://github.com/edurojasr/Windows_Terminal_Theme_Night_Owl)
- Alacritty: [https://github.com/alacritty/alacritty](https://github.com/alacritty/alacritty/wiki/Color-schemes)


#### Light Theme

- iTerm2: [https://github.com/fcaldera/night-owl-light-iterm2](https://github.com/fcaldera/night-owl-light-iterm2)
- Vim: [https://github.com/macguirerintoul/night_owl_light.vim](https://github.com/macguirerintoul/night_owl_light.vim)
- Tilix: [https://github.com/johanhammar/light-owl-tilix](https://github.com/johanhammar/light-owl-tilix)
- Alacritty: [https://github.com/nik27/night-owl-alacritty-theme](https://github.com/nik27/night-owl-alacritty-theme)


## Separate the Editor from the Sidebar

This theme uses contrast sparingly so that when it's applied, it's more meaningful. This can help reduce noise and improve your ability to scan. However, some of the decisions may not work for everyone. One such decision that some disagree on is whether or not to have a separation between the editor and sidebar, and the amount of contrast. If you wish for this to have more visual signifigance, please paste this into your user settings preferences. These are my recommendations for these settings but you can use whatever colors you wish. ☺️
Expand Down Expand Up @@ -108,16 +108,6 @@ The font in the preview image is Dank Mono, [available here](https://dank.sh/).
"editor.fontLigatures": true,
```

The preview image is using [Bracket Pair Colorizer](https://marketplace.visualstudio.com/items?itemName=CoenraadS.bracket-pair-colorizer), a really cool extension that highlights matching brackets. This can help reduce unwanted errors.

I use this setting:

```
"bracketPairColorizer.forceIterationColorCycle": true,
```

![Bracket](bracket.png)

## Misc

This is my first foray into creating a theme, so if you see something amiss, please feel free to [file an issue](https://github.com/sdras/night-owl-vscode-theme/issues)! I'm sure there are things I missed.
Expand Down
Binary file removed bracket.png
View file
Open in desktop
Binary file not shown.
2 changes: 0 additions & 2 deletions themes/Night Owl-Light-color-theme-noitalic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@
"editorWhitespace.foreground": "#d9d9d9",
"editorIndentGuide.background": "#d9d9d9",
"editorCodeLens.foreground": "#403f53",
"editorBracketMatch.background": "#d3e8f8",
"editorBracketMatch.border": "#2AA298",
"editorError.foreground": "#E64D49",
"editorError.border": "#FBFBFB",
"editorWarning.foreground": "#daaa01",
Expand Down
2 changes: 0 additions & 2 deletions themes/Night Owl-Light-color-theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@
"editorWhitespace.foreground": "#d9d9d9",
"editorIndentGuide.background": "#d9d9d9",
"editorCodeLens.foreground": "#403f53",
"editorBracketMatch.background": "#d3e8f8",
"editorBracketMatch.border": "#2AA298",
"editorError.foreground": "#E64D49",
"editorError.border": "#FBFBFB",
"editorWarning.foreground": "#daaa01",
Expand Down
2 changes: 0 additions & 2 deletions themes/Night Owl-color-theme-noitalic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@
"editorIndentGuide.activeBackground": "#7E97AC",
"editorRuler.foreground": "#5e81ce52",
"editorCodeLens.foreground": "#5e82ceb4",
"editorBracketMatch.background": "#5f7e974d",
"editorBracketMatch.border": null,
"editorOverviewRuler.currentContentForeground": "#7e57c2",
"editorOverviewRuler.incomingContentForeground": "#7e57c2",
"editorOverviewRuler.commonContentForeground": "#7e57c2",
Expand Down
2 changes: 0 additions & 2 deletions themes/Night Owl-color-theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@
"editorIndentGuide.activeBackground": "#7E97AC",
"editorRuler.foreground": "#5e81ce52",
"editorCodeLens.foreground": "#5e82ceb4",
"editorBracketMatch.background": "#5f7e974d",
"editorBracketMatch.border": null,
"editorOverviewRuler.currentContentForeground": "#7e57c2",
"editorOverviewRuler.incomingContentForeground": "#7e57c2",
"editorOverviewRuler.commonContentForeground": "#7e57c2",
Expand Down