This repository has been archived by the owner on May 15, 2023. It is now read-only.
Support for webPage.clipRect #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 1, 2015 20:27
|
BTW, the comment for "public void Render(string filename, double ratio, Rectangle clipRect)" is incorrect: top and left are used too |
| @@ -247,16 +262,43 @@ public Bitmap Render() | |||
| /// </summary> | |||
| /// <param name="ratio">zoom ratio</param> | |||
| /// <returns></returns> | |||
| public Bitmap Render(double ratio) | |||
| /// <param name="clipRect">Part of the imaeg captured - Only Height and Width are used right now</param> | |||
|
Thanks @juliensobrier, I knew page.clipRect was broken just hadnt had time to get it working. Will merge when I get a moment to test. Ta! |
added 6 commits
February 10, 2015 15:01
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for clipRect by cropping the full screen image.
Somme additional information on specific code changes:
API/Modules/WebPage.cs
@@ -812,18 +812,26 @@ private Rectangle ClipRect
There was an exception when top/left/width/height was null (set as undefined in Javascript, for example)
API/Modules/WebPage.cs
@@ -266,7 +308,16 @@ public Bitmap Render(double ratio)
There could be a bottom and/or right scroll bar, check for both to add 50px.