Prefer using a virtual to ifs and dynamic casts #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing |
I didn't add it because then I had to add it to the other methods in the class which also are overrides. I'd suggest adding a mandatory override warning on a separate MR and add them all at once. |
|
Ok |
|
IIRC one of the "fix warnings" PRs adds override to most (or all) declarations. |
Vogtinator
approved these changes
Mar 13, 2023
|
You're right, this would be #1664 |
Vogtinator
force-pushed
the
work/apol/prefer-virtual
branch
2 times, most recently
from
911d2a4
to
db2db70
Compare
|
#1664 is merged, can you add |
Vogtinator
force-pushed
the
work/apol/prefer-virtual
branch
from
db2db70
to
bd0d74e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.