seastar-json2code: extract Parameter class and cleanups #2120
Conversation
simpler this way. it also silences following warning: ``` visually indented line with same indent as next logical line [E129] ``` from pycodestyle, see also https://peps.python.org/pep-0008/#indentation. Signed-off-by: Kefu Chai <[email protected]>
less repeatings this way. Signed-off-by: Kefu Chai <[email protected]>
Signed-off-by: Kefu Chai <[email protected]>
this change paves the road to scylladb#2082. so that we can store more properties in the Parameter class in this python script and then translate them into a C++ class which is used to verify and expose the content and schema of a parameter. so that they can be used in `handler_base::verify_mandatory_params()` in a follow-up change. Refs scylladb#2082 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
seastar-json2mode-data-model
branch
from
b6567cc
to
087d3d0
Compare
|
@amnonh hi Amnon, could you help review this change? |
1 similar comment
|
@amnonh hi Amnon, could you help review this change? |
| query_param = Parameter(param) | ||
| if query_param.is_required: | ||
| required_query_params.append(query_param) | ||
| if query_param.enum is not None: |
There was a problem hiding this comment.
@amnonh i am able to parse your question. do you mean "when it is not None"? or do you mean "why shall we check if query_param.enum is not None"?
There was a problem hiding this comment.
why not:
if query_param.enum:
There was a problem hiding this comment.
i see. i wanted to be very specific. as this property is None if "enum" is not in its definition, or otherwise, a list of string. an empty list should probably be handled in generate_code_from_enum(), and an error should be reported instead of being ignored. if i had more bandwidth, i would like to add typing annotations to this script.
|
@scylladb/seastar-maint hello maintainers, could you help merge this change? |
this change paves the road to #2082. so that we can store more
properties in the Parameter class in this python script and then
translate them into a C++ class which is used to verify and expose
the content and schema of a parameter. so that they can be used
in
handler_base::verify_mandatory_params()in a follow-upchange.
Refs #2082