http: add handler_base::verify_mandatory_params() #2084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xemul
reviewed
Feb 9, 2024
include/seastar/http/handlers.hh
Outdated
| @@ -66,8 +67,7 @@ public: | |||
| return *this; | |||
| } | |||
|
|
|||
| std::vector<sstring> _mandatory_param; | |||
|
|
|||
| friend class routes; | |||
There was a problem hiding this comment.
This caught my eye. I think it's better to get const getter for _mandatory_param reference, or move the verify_param() helper to be handler_base's method
There was a problem hiding this comment.
i plan to stuff move info into _mandatory_param, so we can verify the type of the params right in seastar, instead of in the higher application level. so the const getter is a no-go, as it exposes the internals to the public. so i am repurposing this PR to go with the 2nd route.
before this change, this member function was a free function called by `routes::handle()`, but since `handler_base` is closer to the `_mandatory_param` and in the following change, we will store the expected param types in `_mandatory_param`, this makes `handler_base` a better home for the verification function. so to prepare for the change, let's move this free function into handler_base. also, let's mark `_mandatory_param` private, allows us to store the typing of the params into `_mandatory_param`. as this variable should not be visible from the outer world. and the typing information should be opaque from the caller. Refs scylladb#2082 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
more-privacy-for-handler_base
branch
from
185957e
to
6e8f835
Compare
tchaikov
changed the title
|
v2:
|
graphcareful
pushed a commit
to graphcareful/seastar
that referenced
this pull request
Mar 20, 2024
before this change, this member function was a free function called by `routes::handle()`, but since `handler_base` is closer to the `_mandatory_param` and in the following change, we will store the expected param types in `_mandatory_param`, this makes `handler_base` a better home for the verification function. so to prepare for the change, let's move this free function into handler_base. also, let's mark `_mandatory_param` private, allows us to store the typing of the params into `_mandatory_param`. as this variable should not be visible from the outer world. and the typing information should be opaque from the caller. Refs scylladb#2082 Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, this member function was a free function called
by
routes::handle(), but sincehandler_baseis closer to the_mandatory_paramand in the following change, we will storethe expected param types in
_mandatory_param, this makeshandler_basea better home for the verification function. so toprepare for the change, let's move this free function into handler_base.
also, let's mark
_mandatory_paramprivate, allows us to store thetyping of the params into
_mandatory_param. as this variable shouldnot be visible from the outer world. and the typing information should
be opaque from the caller.
Refs #2082
Signed-off-by: Kefu Chai [email protected]