Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Patch sstable_directory to use yielding lister #18223

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

xemul
Copy link
Contributor

@xemul xemul commented Apr 11, 2024

No description provided.

@xemul xemul requested a review from tgrabiec as a code owner April 11, 2024 17:06
@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
✅ - Container Test
✅ - dtest
✅ - dtest with topology changes
❌ - Unit Tests

Failed Tests (3/30219):

Build Details:

  • Duration: 2 hr 29 min
  • Builder: spider2.cloudius-systems.com

So that it does not fallback to fallback generator, in which case the whole thing stops making any sense

Signed-off-by: Pavel Emelyanov <[email protected]>
@xemul xemul force-pushed the br-sstables-use-experimental-yielding-lister branch from f634267 to 4c469e1 Compare April 12, 2024 11:25
@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Container Test
✅ - dtest
✅ - dtest with topology changes
✅ - Unit Tests

Build Details:

  • Duration: 2 hr 3 min
  • Builder: spider2.cloudius-systems.com

@xemul
Copy link
Contributor Author

xemul commented Apr 15, 2024

🔴 CI State: FAILURE

✅ - Build ✅ - Container Test ✅ - dtest ✅ - dtest with topology changes ❌ - Unit Tests

Failed Tests (3/30219):

[empty] 🔍

Without cfd36e5 (checked-file: Implement experimental_list_directory patch from this PR) the lister end up using fallback generator and steps on scylladb/seastar#2190

@denesb
Copy link
Contributor

denesb commented Apr 16, 2024

Need more details as well as motivation in the cover letter.

@xemul
Copy link
Contributor Author

xemul commented Apr 16, 2024

Need more details as well as motivation in the cover letter.

Yes, definitely. The PR is here just to have CI run and to track the aforementioned seastar issue. Once it's all settled, I'll brush the PR up properly

@xemul xemul marked this pull request as draft May 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants