Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): run azure on multiple vm images #2976

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

ilan-gold
Copy link
Contributor

  • Release notes not necessary because:

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.49%. Comparing base (c68557c) to head (b253e93).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2976   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files         116      116           
  Lines       12911    12911           
=======================================
  Hits         9747     9747           
  Misses       3164     3164           

Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the pearson residual tests, that's an easy fix. np.dtype("int") is np.int32 on windows, and np.int64 everywhere else. So the tests should just be is np.int64.

test_leiden_random_state[igraph] does seem to be showing that the random state is at least acting differently here.

@ilan-gold
Copy link
Contributor Author

@ivirshup yup, commented that. we need to find someone with a windows machine, I think.

@ivirshup
Copy link
Member

From discussion at triage/ sprint planning:

  • We're not sure we want to support windows that much
  • We'll leave this untouched for now, and probably won't merge until we also have an official stance on support level for windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants