add the default parameter to get_output_value #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys! Good job decoupling this from Scrapy!
I’ve been thinking about the possibility of adding a default value for the
get_output_value()
.So as an example, you could do:
and you would receive the value for
name
if it's available or'Foobar'
if it's not available.The implementation seems quite simple, but there are a lot of scenarios that I tried to reproduce in the tests.
Could you?
1. Let me know if you like the idea.
I decided to implement it because I frequently find something similar to:
2. Check the tests I added and see if it's what you expect or not.
If you see any missed case you can also let me know it.
Thanks in advance!