TST: stats: refactor tests of normality tests #20756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
scipy.stats
maintenance
mdhaber
commented
May 20, 2024
|
|
||
| # nan_policy only compatible with NumPy arrays |
There was a problem hiding this comment.
Delete all these. nan_policy is implemented with axis_nan_policy decorator and tested with strong, property-based tests.
mdhaber
commented
May 20, 2024
| @@ -6423,26 +6376,6 @@ def test_axis(self, xp): | |||
| xp_assert_close(res.pvalue, resT.pvalue) | |||
|
|
|||
|
|
|||
| @array_api_compatible | |||
| def test_skewtest_too_few_samples(xp): | |||
There was a problem hiding this comment.
Moved these up into classes.
mdhaber
force-pushed
the
normality_test_tests
branch
from
cd9dc10
to
35b4028
Compare
j-bowhay
reviewed
May 21, 2024
| raise ValueError( | ||
| f"skewtest is not valid with less than 8 samples; {n} samples were given.") | ||
| message = ("`skewtest` requires at least 8 observations; " | ||
| f"{n} observations were given.") |
There was a problem hiding this comment.
Maybe if you're coming near here in a future PR, for consistency with the kurtosistest
Suggested change
| f"{n} observations were given.") | |
| f"{n=} observations were given.") |
There was a problem hiding this comment.
Oops. Yes actually I can do that in gh-20694, which will have merge conflicts with this one.
Comment on lines
-6257
to
-6268
| # Test axis=None (equal to axis=0 for 1-D input) | ||
| res = stats.normaltest(x_xp, axis=None) | ||
| xp_assert_close(res.statistic, st_normal) | ||
| xp_assert_close(res.pvalue, pv_normal) | ||
|
|
||
| res = stats.skewtest(x_xp, axis=None) | ||
| xp_assert_close(res.statistic, st_skew) | ||
| xp_assert_close(res.pvalue, pv_skew) | ||
|
|
||
| res = stats.kurtosistest(x_xp, axis=None) | ||
| xp_assert_close(res.statistic, st_kurt) | ||
| xp_assert_close(res.pvalue, pv_kurt) |
There was a problem hiding this comment.
Assume this is tested elsewhere as I couldn't see these tests in the updated version?
There was a problem hiding this comment.
Yup. axis=None is tested by generic, property-based tests in test_axis_nan_policy.py.
j-bowhay
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Follow-up to gh-20597, gh-20715, gh-20736
What does this implement/fix?
As discussed in referenced issues, this PR refactors tests of
stats.skewtest,stats.kurtosistest, andstats.normaltestto make them more maintainable.