MAINT: stats.gstd: return result rather than raising #20696
Merged
+51
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
scipy.stats
maintenance
Kai-Striega
approved these changes
May 11, 2024
mdhaber
commented
May 11, 2024
|
@mdhaber We've had two approvals on the mailing list and the failures on the CI are unrelated. Would you like to add anything before I give it a final review? |
|
Besides the suggestions, nope. Feel free to commit those before merge. |
Co-authored-by: Matt Haberland <[email protected]>
Co-authored-by: Matt Haberland <[email protected]>
Kai-Striega
approved these changes
May 25, 2024
|
Looks like CI is happy. I took the liberty of assuming this would make it and adding a release note. |
|
Merged, thanks for your work @mdhaber! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
gh-20285
What does this implement/fix?
gh-20285 noted changes to
stats.gstdthat would make it more amenable to the addition of array API support. This implements those changes. It also deprecates support for masked arrays, sincegstdseems to be unique amongstatsfunctions in that it advertises support for masked arrays such that it returns a masked array with no masked elements (many handle them, but other functions return regular arrays).Additional information
See #20285 (comment) for context and additional rationale.