BUG: sparse: Fix summing duplicates for CSR/CSC creation from (data,coords) #20687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scipy.sparse
defect
tylerjereddy
added
the
backport-candidate
perimosocordiae
requested changes
May 13, 2024
perimosocordiae
approved these changes
May 15, 2024
|
Thanks, merged! |
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
May 15, 2024
…oords) (scipy#20687) * test and then fix duplicates for CSR/CSC creation from (data,coords) * remove has_canonical_format check when summing duplicates.
10 tasks
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20670
CSC and CSR
__init__witharg1=(data, coords)input no longer checked for and summed duplicates after #19962.This PR adds tests for this case in the constructors and also for
COO.tocsc()andCOO.tocsr()which use much of the same code. This does not affect thesetdiagcode path due to the lack of a way to introduce duplicates there -- though setdiag uses some of the same code.