Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Corsika7ID (+converter) and Particle.from_nucleus() #426

Merged
merged 30 commits into from
Oct 27, 2022
Merged

Add Corsika7ID (+converter) and Particle.from_nucleus() #426

merged 30 commits into from
Oct 27, 2022

Commits on Oct 11, 2022

  1. add Particle.from_nuclear_info +test for that

    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    598bc33 View commit details
    Browse the repository at this point in the history

  2. add Corsika7ID 

    - added the class Corsika7ID (adapted from the class Geant3ID)
- some tests for the class
- added the script that generated the conversion table
- Corsika7ID has some functionality to see if conversion to PDGID is
  sensible: Check if the Corsika7ID relates to a particle via
  .is_particle(), get the human readable name via .name()
    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    907130b View commit details
    Browse the repository at this point in the history

  3. add documentation to corsika/gen_conversion_table

    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    d21ab99 View commit details
    Browse the repository at this point in the history

  4. add Corsika7Id.from_particle_description 

    - This allows easy conversion from the corsika7 output to Corsika7ID
    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    bb32bc4 View commit details
    Browse the repository at this point in the history

  5. add Corsika7ID to exports

    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    114957c View commit details
    Browse the repository at this point in the history

  6. change README for Corsika7ID and from_nucleus_info

    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    2c9d834 View commit details
    Browse the repository at this point in the history

  7. change README changes more readable

    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b498fe5 View commit details
    Browse the repository at this point in the history

  8. added copyright header

    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    6d8b65b View commit details
    Browse the repository at this point in the history

  9. changed order of imports 

    More structured order
    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    cada05c View commit details
    Browse the repository at this point in the history

  10. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    98d14bf View commit details
    Browse the repository at this point in the history

  11. add tests for gen_conversion_table

    @The-Ludwig
    The-Ludwig committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    d03cdd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. udpate README.rst to simplilfy language on corsika doc 

    Co-authored-by: Eduardo Rodrigues <[email protected]>
    @The-Ludwig @eduardo-rodrigues
    The-Ludwig and eduardo-rodrigues committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    13b352c View commit details
    Browse the repository at this point in the history

  2. Update README.rst

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    fed51ca View commit details
    Browse the repository at this point in the history

  3. Update src/particle/particle/particle.py

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    841192f View commit details
    Browse the repository at this point in the history

  4. Update src/particle/corsika/corsika7id.py

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    643fc36 View commit details
    Browse the repository at this point in the history

  5. Update src/particle/corsika/corsika7id.py

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    d6b172e View commit details
    Browse the repository at this point in the history

  6. Update src/particle/corsika/corsika7id.py

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    346207a View commit details
    Browse the repository at this point in the history

  7. Update src/particle/corsika/corsika7id.py

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    9f24f4e View commit details
    Browse the repository at this point in the history

  8. Update src/particle/corsika/gen_conversion_table.py

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    809b344 View commit details
    Browse the repository at this point in the history

  9. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    f7176b2 View commit details
    Browse the repository at this point in the history

  10. Apply fast implemented suggestions from code review 

    Co-authored-by: Eduardo Rodrigues <[email protected]>
    @The-Ludwig @eduardo-rodrigues
    The-Ludwig and eduardo-rodrigues committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    abc30e3 View commit details
    Browse the repository at this point in the history

  11. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    9ef867b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. implement suggestions

    @pre-commit-ci @The-Ludwig
    pre-commit-ci[bot] authored and The-Ludwig committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    59e3b8b View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Apply suggestions from code review

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    4e42800 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    addf9e0 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    019298e View commit details
    Browse the repository at this point in the history

  4. restore unneeded update of pdgid_to_lhcbname.csv

    @The-Ludwig
    The-Ludwig committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    cdd6eaf View commit details
    Browse the repository at this point in the history

  5. clearify error message in to_pdgid

    @The-Ludwig
    The-Ludwig committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    0dfc02b View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review

    @eduardo-rodrigues
    eduardo-rodrigues committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    aa9dc93 View commit details
    Browse the repository at this point in the history

  7. supress pylint warnings

    @The-Ludwig
    The-Ludwig committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    cffa874 View commit details
    Browse the repository at this point in the history