-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDSRV-527 #5564
base: development/7.70
Are you sure you want to change the base?
CLDSRV-527 #5564
Conversation
POST Object saves an object to bucket with the env variables set to S3DATA=mem and S3METADATA=file. Currently, bucket policy checking and Vault auth is effectively bypassed. Next steps are to move the form data recovery/parsing to the API level where we can better separate the form fields from the file data. In the future, this may allow us to get authentication details before from the fields by moving them before file data handling, something that may be a performance vulnerability if handled too early
Hello kaztoozs,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Both MD and File data are now saved properly, tested with list-objects-v2 and getObject followed by a cat of the received file to check contents. This code still currently bypasses authentication.
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Pull request template
Description
Motivation and context
Why is this change required? What problem does it solve?
Related issues
Please use the following link syntaxes #600 to reference issues in the
current repository
Checklist
Add tests to cover the changes
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
Sign your work
In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work
Thank you again for contributing! We will try to test and integrate the change
as soon as we can.