Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to warn if classes, methods, objects, and packages match a… #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamkasztenny
Copy link
Contributor

@adamkasztenny adamkasztenny commented Aug 12, 2016

This way, a certain field can be rejected, e.g.

 <check class="org.scalastyle.scalariform.ClassNamesChecker" level="warning" enabled="true">
  <parameters>
   <parameter name="regex"><![CDATA[Util]]></parameter>
   <parameter name="match"><![CDATA[false]]></parameter>
  </parameters>
 </check>

will reject classes that have Util in them.

Added tests as well. If you choose to add this feature, I'll update the documentation and website as well.

@codecov-io
Copy link

Current coverage is 87.32% (diff: 100%)

No coverage report found for master at 129957e.

Powered by Codecov. Last update 129957e...47a2eb5

@adamkasztenny
Copy link
Contributor Author

Why does the coverage difference say 100% when the previous coverage was 87.09%?

@matthewfarwell
Copy link
Member

Thanks for the PR. I'll have a look at it this week. For the coverage, I have no idea. It used to work.

@matthewfarwell
Copy link
Member

Are you still interested in doing this?

@canoztokmak
Copy link
Contributor

@matthewfarwell do you want me to take over this change ?

@Adowrath
Copy link

@SlideOn The diff percentage says "How many % of the changes made in this PR are covered?". Codecov uses many metrics to compare coverage, and that's one of them. It's like a "how thoroughly is this change tested?".

@adamkasztenny
Copy link
Contributor Author

adamkasztenny commented Jul 14, 2018

@matthewfarwell Sorry, I haven't looked at this in forever. From what I remember, I did all the code changes necessary, only the docs need to be updated. Is that what you're referring to? The merge conflicts as well, I guess.

@Adowrath Thanks, that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants