Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pop up client ui / UX #1720

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

cameronrohani
Copy link
Contributor

Remove scale from client animation which was (most likely) giving a windows user blurry text

Increase modal size

Create better contrast for click out areas for dark mode

Before:
image

After:
image

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 5362b64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@scalar/api-reference Patch
@scalar/api-reference-react Patch
@scalar/cli Patch
@scalar/express-api-reference Patch
@scalar/fastify-api-reference Patch
@scalar/hono-api-reference Patch
@scalar/nestjs-api-reference Patch
@scalar/nextjs-api-reference Patch
@scalar/nuxt Patch
@scalar/play-button Patch
@scalar/docusaurus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copy link

relativeci bot commented May 13, 2024

#1511 Bundle Size — 1.79MiB (0%).

5362b64(current) vs 342ec63 main#1510(baseline)

Warning

Bundle contains 4 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#1511
     Baseline
#1510
No change  Initial JS 1.79MiB 1.79MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 1072 1072
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 160 160
No change  Duplicate Packages 4 4
Bundle size by type  no changes
                 Current
#1511
     Baseline
#1510
No change  JS 1.79MiB 1.79MiB

Bundle analysis reportBranch cam/fix-client-modal-blur-and-si...Project dashboard

@marclave marclave merged commit 5d0e06c into main May 14, 2024
11 checks passed
@marclave marclave deleted the cam/fix-client-modal-blur-and-sizing branch May 14, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants