Attempt to address #35 #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oaded and try to connect to sockets, making session id in sockets compatible with socket io 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making sure socket io loads client side before all other scrips are loaded and try to connect to sockets, making session id in sockets compatible with socket io 1.0
I was having the same problems as in #35, where the io object was not defined before sockets was call in scripts loaded by the require-jquery script so I moved the script loader to the bottom of the index layout file.
Additionally, client side was mad at me about the socket session id when I tried the blinking light demo on the front page. I made an update to Noduino.Socket.js to use socket.io.engine.id as in socket v 1.0 and above.
This library is awesome!