Fix RUN-PROGRAM failing if an output file doesn't exist. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a pathname is passed as :OUTPUT or as :ERROR to RUN-PROGRAM, the target file is created if it doesn't exist. The problem was that when :IF-OUTPUT-EXISTS / :IF-ERROR-EXISTS is also specified, RUN-PROGRAM signaled an error if the file cannot be found. This behavior is caused by NIL being passed as :IF-DOES-NOT-EXIST argument to OPEN, so let's fix it by explicitly passing :IF-DOES-NOT-EXIST :CREATE.
|
still happens on: |
|
There is no bug here. You should be passing |
|
I still think that this is not the right fix but withdraw my claim that there is no bug here. Please see also https://bugs.launchpad.net/sbcl/+bug/789817/comments/2 |
|
still happens on |
lichtblau
pushed a commit
that referenced
this pull request
May 22, 2018
The concept remains, but the previous implementation caused the compiler to trip
over its own shoelaces while trying to walk (pun intended), and caused code
analyzers to go awry. It's near impossible to produce a minimal reduction
because by definition all examples seem to involve a lot of hair: macros that
expand inside-out by MACROEXPANDing their arguments, and somehow accidentally
misled the compiler to thinking that the inside code was toplevel.
The failures in previously working code were several. One was an attempt by
the compiler to call GET-DEFINED-FUN on macrolets (redacted backtrace below),
which causes an error in source-path finding, which we might want to fix as a
bug in its own right, except that it goes away after this patch.
Attempting to hack around that in IR1-CONVERT-LAMBDALIKE by simply never calling
GET-DEFINED-FUN on things named (MACROLET x) produces a different error, which
is the attempt to store (MACROLET mumble) into a %DEBUG-NAME of a CLAMBDA:
'The value (MACROLET mumble) is not of type (OR NULL (NOT (SATISFIES SB-INT:LEGAL-FUN-NAME-P)))
when setting slot SB-C::%DEBUG-NAME of structure SB-C::CLAMBDA'
So this changes removes MACROLET as a legal fun name, which makes it never reach
the named lambda case in IR1-CONVERT-LAMBDALIKE, and moreover, MAKE-MACRO-LAMBDA
never returns a top-level-ish lambda from a type derivation perspective.
I can't explain why these never mattered, because it sure looks as if named
macro lambdas always went through the named-lambda path that global functions
did. But at exactly the change which introduced TOP-LEVEL-NAMED-LAMBDA,
without this patch, we would see in various guises:
SB-INT:INVALID-ARRAY-INDEX-ERROR: Invalid index 41 for (SIMPLE-VECTOR 1), should be
a non-negative integer below 1. while executing: COMPILE
Unhandled SB-INT:INVALID-ARRAY-INDEX-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING {10006F05B3}>:
Invalid index 41 for (SIMPLE-VECTOR 1), should be a non-negative integer below 1.
Backtrace for: #<SB-THREAD:THREAD "main thread" RUNNING {10006F05B3}>
0: (SB-C::FIND-SOURCE-ROOT 41 #<SB-C::SOURCE-INFO {100F483203}>)
1: (SB-C::FIND-ORIGINAL-SOURCE (#1=(SB-C::%FUNCALL #2=#:G23 . #3=(#:G22))
#4=(LET ((#5=#:VAL26 #1#)) (UNLESS #5# (RETURN-FROM #6=#:BLOCK24 NIL)))
(BLOCK #7=#:WRAPPER25 . #8=(#4#)) ...))
2: (SB-C::FIND-ERROR-CONTEXT ((MACROLET DEFINE-mumble)) NIL)
3: (SB-C::NOTE-UNDEFINED-REFERENCE (MACROLET DEFINE-mumble) :FUNCTION)
4: (SB-C::FIND-GLOBAL-FUN (MACROLET DEFINE-mumble) NIL)
5: (SB-C::FIND-FREE-FUN (MACROLET DEFINE-mumble) "shouldn't happen! (defined-fun)")
6: (SB-C::GET-DEFINED-FUN (MACROLET DEFINE-mumble) (#:EXPR #:ENV))
7: (SB-C::IR1-CONVERT-LAMBDALIKE (SB-INT:NAMED-LAMBDA (MACROLET DEFINE-mumble)
(#1=#:EXPR #2=#:ENV) (DECLARE (IGNORE #2#))
(DECLARE (OPTIMIZE (SB-EXT:INHIBIT-WARNINGS 1))) ...))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a pathname is passed as :OUTPUT or as :ERROR to RUN-PROGRAM, the
target file is created if it doesn't exist. The problem was that when
:IF-OUTPUT-EXISTS / :IF-ERROR-EXISTS is also specified, RUN-PROGRAM
signaled an error if the file cannot be found. This behavior is caused
by NIL being passed as :IF-DOES-NOT-EXIST argument to OPEN, so let's fix
it by explicitly passing :IF-DOES-NOT-EXIST :CREATE.
An example:
If /tmp/out.txt doesn't exist, an error is signalled unless you remove
:if-output-exists :overwrite.