Use NEWS date instead of build date #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good. This date call works with GNU date and BSD date. Also allow to override hostname.
|
Anything I can do to help get this reviewed/tested/merged ? |
Send the patch to the sbcl-devel mailing list https://sourceforge.net/p/sbcl/mailman/. SBCL doesn't use GitHub for development/PRs. |
|
For the record: https://sourceforge.net/p/sbcl/mailman/sbcl-devel/thread/CAOrNasxpuRSJZ613PKhD-kU%3DG9-adExNEGB%2BqL6D3XYWBx25zg%40mail.gmail.com/ remained unmerged. We apply a different downstream patch instead: https://code.opensuse.org/package/sbcl/blob/master/f/sbcl-use-SOURCE_DATE_EPOCH-for-build-id.patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
NEWSfile date instead of build datein order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.
This date call works with GNU date and BSD date.
Also allow to override hostname.
This PR was done while working on reproducible builds for openSUSE.