Xml/attachments options bugfix, MTOM support for attachments, better Nori options passthrough

[ekzobrain]

What kind of change is this?

Bugfixes + new feature

Did you add tests for your changes?

Currently no

Summary of changes

Add MTOM support for SOAP attachments (previously no support)
Fix request logging when message containt non-ascii characters (log writing failure occured)
Fix using attachments together with 'xml' option (when xml option was provided, attachments option was ignored)

[ekzobrain]

@pcai what about merging this? we use it in production for two years already

[Skulli]

Thanks for your work. Could you describe how to use it? For example get the attachments of a given request?
In https://github.com/savonrb/savon-multipart/blob/master/spec/savon/soap/response_spec.rb you can access attachments via response.attachments.

[ekzobrain]

@Skulli is far as I remember, there were no changes in public API regarding request/response attachments, except fixing a bug, when both "attachments" and "xml" options were used together in locals.

The main feature was support for MTOM attachments encoding: https://www.ibm.com/docs/en/integration-bus/10.0?topic=services-what-is-soap-mtom
It automatically recognizes this encoding (and decodes as appropriate) for response attachments, and one should explicitely define wheather he wants to send request attachments in this encoding (new "mtom" option, defaults to false, backward compatible).
We implemented it for an API, that only supported sending attachments in this encoding.

Request example:

client = Savon.client({
  multipart: true,
  ...
})
client.call(:some_operation, {
  mtom: true, # new option, default=false
  attachments: [...],
})

[pcai]

@netcitylife please address the merge conflicts and lack of tests and I can merge.

[bihterulu]

This is working, what can we do to solve these issues which blocks the merge process?

[olleolleolle]

Minor: this MTOM mime type could also be extracted to a constant, so that both branches are harmonious, looking uniform.

[olleolleolle]

This is working, what can we do to solve these issues which blocks the merge process?

Missing in order to merge: tests for the new behaviour.