[save-] handle empty delimiter when safety_first #2421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
--safety-first
, saving a sheet fails when using'\x00'
as a delimiter.echo "col\none\0two" |vd --safety-first --delimiter= -f tsv -
then executesave-sheet
:This PR changes the behavior to fail, with an explanatory message, when the delimiter is
'\x00'
,'\r'
, or'\n'
.