Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for hide/show current cursor column in columns sheet. #2394

Closed
wants to merge 1 commit into from

Conversation

blais
Copy link

@blais blais commented Apr 28, 2024

Minor change adding a way to toggle to show a single column in the Columns metasheet.
I'm finding myself a bit annoyed having to (gv) show all and then rehide some of the columns.

(Feel free to change the binding overrides to be more in line with the holistic choices across the tool.
Thank you for this wonderful tool! :-) )

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2024

CLA assistant check
All committers have signed the CLA.

@saulpw
Copy link
Owner

saulpw commented May 19, 2024

Thanks for putting together this contribution, @blais! I'd like to know more about when you have this issue, and to think about other possible solutions.

First off, did you know that you can edit the column width on the Columns Sheet to do the same? It's a few extra keystrokes, which is annoying, but consistent with how VisiData works already. And also, did you know that if you hide a column accidentally, you can use Shift+U to undo the hiding without going to the Columns Sheet?

I'm open to some of what you propose here. Particularly since using aggregators makes little sense on the Columns Sheet, so rebinding + shouldn't be a problem. But I'm worried that it might be confusing, since that binding doesn't work like that in any other area of the program. Also, if we change the - keybinding on the Columns Sheet to hide/show on the source sheet, should other column-oriented commands, like _ for column resizing and # to type as integer, work the same way?

@saulpw
Copy link
Owner

saulpw commented May 24, 2024

Well, @blais, your PR caused me to think about the problem of unhiding hidden columns, and I wound up implementing something (just pushed) that I hope will make it easier in general. Thank you so much for your PR; I'm going to close it for now, and if you have other ideas I would love if you opened another PR or issue.

@saulpw saulpw closed this May 24, 2024
@anjakefala anjakefala changed the title Add bindings for hide/show current cussor column in columns sheet. Add bindings for hide/show current cursor column in columns sheet. May 24, 2024
@blais
Copy link
Author

blais commented May 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants